-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMD HW AV1 with Color Range "Full" outputs wrong colors #9121
Comments
What exactly are you playing the file back in? Many video players don't properly handle full color range, and we don't recommend using it in nearly all cases. |
I‘m using mpv to play these files. There looks like no difference between "Limited" and "Full" for the AMD HW H.265/H264 encoder. And the video files of AMD HW AV1 encoder are attached, see two videos.zip |
What is your use case for full? Most video editing applications and video streaming platforms expect a limited-range (partial) input; streaming or recording in Full range will result in color clipping, often reported as overly bright or dark image. |
Import to Davinci to edit, A larger color range helps me manipulate colors. |
Doesn't seem like a bug, though, and seems to work exactly as intended. Limited matches the original, while using Full alters the original. |
But from AOM AV encoder or others encoder, it not same as AMD HW AV1 encoder: mediainfo outputs of AOM-limited:
mediainfo outputs of AOM-full:
|
@akiirui Could you do the same test with mp4, and upload both partial and full? |
Indeed it is the same, but it ruled out an important factor :) The code is there to set full range, and seeing as the code is working for HEVC, I believe the path is valid.
Unfortuantely its not possible for me to confirm, seeing as I don't have an AMD av1 encoder avaliable to me. As per AMD's documentation, that seems to be all that should be required, unlike HEVC, which requires:
There is no Nonetheless, as far as I can see in the bitstream of the files you provided, the full range flag is not set (confirmed with a working aom-av1 file), so I think there is a possibility that this might be an AMF issue. seq_header_obu\color_config(): In the working full range file from encoded with aom, this value is set to 1. If you are able to confirm the issue with AMD's tools, like TranscodeHW, you could submit a bug report/issue on their github. Or perhaps reproducing with ffmpeg will suffice as validity (tested 2 implementations). |
@flaeri Thanks. In AMF_Video_Encode_AV1_API.md - Maybe it's an AMF issue, I'll open an issue for it. |
The 10-bit display while recording 8-bit content? From the log:
Without test tables(images) it is hard to say where the error is (display/encode/screenshot etc). I have few test charts for 8-bit: |
@SuslikV 1080p test charts here. |
What name: I'm not common with the AV1 encoder but it seems this media file has no range flag set at all, so almost any player will assume a partial range video here (while it can be full range and from what I see - I assume it is). You can try make new shortcut to the mpv player and add in the end |
Just color range "full".
Yep, that let this video displayed normally. Such as @flaeri says, AMF av1 encoder doesn't set the full range flag. Maybe that's what's causing the problem. Thanks. |
This is a long standing issue with OBS not AMF, try recording with Game Bar or Radeon Software and you'll get full HDR in the video. I reported this back in 2022 and was ignored, #7451 |
Operating System Info
Windows 11
Other OS
No response
OBS Studio Version
Other
OBS Studio Version (Other)
29.1.3
OBS Studio Log URL
https://obsproject.com/logs/lXfDZatEdQGpF247
OBS Studio Crash Log URL
No response
Expected Behavior
Use AMD HW AV1 encoder, when different color range "limited" and "full" the colors should be nearly identical when viewed with the naked eye.
Current Behavior
Use AMD HW AV1 encoder, when the different color ranges "limited" and "full", the color is different when viewed with the naked eye.
mediainfo outputs of range-limited.mkv:
mediainfo outputs of range-full.mkv:
Screenshot of range-limited.mkv:
Screenshot of range-full.mkv:
The original background imange:
two videos.zip
Steps to Reproduce
AMD HW AV1
NV12
, "Color Space" tosRGB
and "Color Range" tolimited
.NV12
, "Color Space" tosRGB
and "Color Range" tofull
.Anything else we should know?
No response
The text was updated successfully, but these errors were encountered: