Rework format strings to use standard values #448
+36
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
force-pushed
the
format_strings
branch
from
3b19d12
to
4069f86
Compare
It's a common macro that can be used in other places.
It's always true for all platforms.
See https://en.cppreference.com/w/cpp/types/integer When compiled in C, it depends whether it's the Microsoft flavor or the standard C format. Not whether it's Win32 or not. Clang or GCC use the proper string formats on windows.
dheitmueller
pushed a commit
to LTNGlobal-opensource/vlc-3.0
that referenced
this pull request
May 24, 2024
Patchsets sent upstream: - GPUOpen-LibrariesAndSDKs/AMF#448 - GPUOpen-LibrariesAndSDKs/AMF#449 - GPUOpen-LibrariesAndSDKs/AMF#450 - GPUOpen-LibrariesAndSDKs/AMF#451 - GPUOpen-LibrariesAndSDKs/AMF#452 (cherry picked from commit d0c4704681541f205a38fc4a72ce01a0c61a982a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since C+11 it is properly defined in C++. For C it depends on the compiler (MS or not), not the targeted platform.
The wide variants can always be defined as wide variants of the original format string.