Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasePipelineManager::Pipeline::release_vulkan_objects releases layout when shouldn't? #3

Closed
DeanoC opened this issue Aug 1, 2016 · 2 comments
Assignees
Labels

Comments

@DeanoC
Copy link

DeanoC commented Aug 1, 2016

/*

  • The function does NOT release the layout object, since it's owned by the Pipeline Layout manager.
    */
    void Anvil::BasePipelineManager::Pipeline::release_vulkan_objects()

The comment say it doesn't release the layout but the code actually does. In my tests the code causes a crash, so I think the comment is right and the code wrong.

Not sure if just removing the release will cause leaks (though I've done that on my local copy at them mo.

@DominikWitczakAMD DominikWitczakAMD self-assigned this Aug 9, 2016
@DominikWitczakAMD
Copy link
Contributor

Thanks for reporting this problem. We're currently in the process of moving to automated pointers, which may fix this issue, but I'm going to make sure the problem is addressed before we release an update.

@DominikWitczakAMD
Copy link
Contributor

Should be fixed in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants