Notification adjustments #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an issue where the notification would close without launching the app if the user clicked on the notification body rather than the action button. our notifications now include a "defaultAction" field in their data object that will be used when the "action" is empty
increases spontaneous notification cooldown time and adjusts probabilities to increase time between reminders
grarer
added
the
UI/UX improvement
porterehunley
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #96, solving an issue where notifications were dismissed without opening the app when the user clicks the notification body rather than the action button
adds icon and badge to notifications, resolves #82
increases cooldown and reduces frequency of spontaneous notifications, resolves #98