Sprint 3 followups #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaces the contact methods popup, which was inconsistently capable of directly linking to some platforms, with a simple and consistent button that copies the contact method to the clipboard.
fixes the description of how to initialize the database adds explanation of initialize_examples.sql organizes all server command line arguments into one list
we learned during the notifications feature that pg-format can produce an invalid sql string when interpolating an empty array. to avoid this every happening in the contact methods endpoint, we skip inserting methods if there are no methods to insert.
JuanCaicedo119
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion at today's meeting, i've simplified the start chat page so that each card just has a button to copy the contact ID to the clipboard.
I've also fixed up the readme, prevented a possible sql exception in the backend handler for updating contact methods, and removed the unintended black outline that appeared around the logo when it was clicked.