-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting MAJORPROGRAM transformation tracking #3821
Conversation
Terraform plan for dev No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #662 |
Terraform plan for meta No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #662 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0a7d257 |
the InspectionRecord table if at least one of the records has been | ||
modified by the transformation. If no records related to the given section | ||
were modified, then we do not save change_records into InspectionRecord. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tracking should happen outside of the if statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. I see you addressed this in another PR. I belive the comment update was not meant for xform_address_state
but for xform_missing_major_program
instead.
Follow-up of #3784
In this PR:
MAJORPROGRAM
fieldTesting:
MAJORPROGRAM
and has aTYPEREPORT_MP
set, as well as other rows with proper Y/N valueshistoric_data_migrator
on that audit and it should migrate without issueMAJORPROGRAM
was replaced with "Y", while otherMAJORPROGRAM
values remain as-isis_major
in the dissemination_federalaward table should be "Y"MAJORPROGRAM
and does NOT haveTYPEREPORT_MP
set, as well as other rows with proper Y/N valueshistoric_data_migrator
on that audit and it should migrate without issueMAJORPROGRAM
was replaced with "N", while otherMAJORPROGRAM
values remain as-isis_major
in the dissemination_federalaward table should be "N"PR checklist: submitters
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)git status | grep migrations
. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrations
to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.