Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auditee info form server side validation #1821

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Auditee info form server side validation #1821

merged 6 commits into from
Aug 16, 2023

Conversation

timoballard
Copy link
Contributor

@timoballard timoballard commented Aug 15, 2023

Resolves #1816

  • Makes UEI, start, and end dates required fields on the server side
  • Adds server side validation of UEI against SAM.gov
  • Adds server side validation that start date is earlier than end date
  • Updates related view tests, which previously were not submitting data in the correct format
Screen.Recording.2023-08-15.at.3.41.35.PM.mov

@timoballard timoballard temporarily deployed to dev August 15, 2023 16:13 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 15, 2023 16:13 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Terraform plan for meta

Plan: 4 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.environments["dev"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../dev/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["preview"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../preview/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["production"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../production/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

  # module.environments["staging"].local_file.cf_org will be created
  + resource "local_file" "cf_org" {
      + content              = <<-EOT
            cf_org_name = "gsa-tts-oros-fac"
        EOT
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0644"
      + filename             = "./../staging/orgname.auto.tfvars"
      + id                   = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #111

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Terraform plan for dev

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #111

@timoballard timoballard temporarily deployed to dev August 15, 2023 16:14 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 15, 2023 16:14 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to dev August 15, 2023 18:30 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 15, 2023 18:30 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to dev August 15, 2023 18:32 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 15, 2023 18:32 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to dev August 15, 2023 20:15 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 15, 2023 20:15 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to meta August 15, 2023 20:41 — with GitHub Actions Inactive
@timoballard timoballard temporarily deployed to dev August 15, 2023 20:41 — with GitHub Actions Inactive
@timoballard timoballard marked this pull request as ready for review August 15, 2023 20:43
Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review support from HDMS and JP. LGTM.

@jadudm jadudm merged commit 603028d into main Aug 16, 2023
13 checks passed
@jadudm jadudm deleted the tdb/require-uei branch August 16, 2023 14:08
@rnovak338 rnovak338 mentioned this pull request Oct 8, 2024
18 tasks
@jperson1 jperson1 mentioned this pull request Oct 9, 2024
18 tasks
@rnovak338 rnovak338 mentioned this pull request Oct 11, 2024
18 tasks
This was referenced Oct 16, 2024
@rnovak338 rnovak338 mentioned this pull request Oct 21, 2024
18 tasks
@asteel-gsa asteel-gsa mentioned this pull request Nov 4, 2024
18 tasks
@jperson1 jperson1 mentioned this pull request Nov 8, 2024
18 tasks
@asteel-gsa asteel-gsa mentioned this pull request Nov 8, 2024
18 tasks
@phildominguez-gsa phildominguez-gsa mentioned this pull request Nov 15, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAC - Bug: UEI still not required
3 participants