Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-12759: Update Personal key Help Center article line #1228

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Mar 27, 2024

馃帿 Ticket

LG-12759

馃洜 Summary of changes

Changes text on a personal key help page (https://login.gov/help/manage-your-account/personal-key/) from "You can find your current personal key on your account page" to "You can get a new personal key on your account page".

@jc-gsa jc-gsa requested a review from a team March 27, 2024 22:07
zachmargolis
zachmargolis previously approved these changes Mar 27, 2024
aduth
aduth previously approved these changes Mar 28, 2024
mdiarra3
mdiarra3 previously approved these changes Mar 28, 2024
@jc-gsa jc-gsa force-pushed the LG-12759-Update-personal-key-help-article branch from 3d7fc1e to 6cb6511 Compare March 28, 2024 21:17
@jc-gsa jc-gsa dismissed stale reviews from mdiarra3, aduth, and zachmargolis via d4e19a8 March 28, 2024 22:15
@jc-gsa jc-gsa force-pushed the LG-12759-Update-personal-key-help-article branch from 5076273 to d4e19a8 Compare March 28, 2024 22:15
@jc-gsa
Copy link
Contributor Author

jc-gsa commented Mar 28, 2024

Added signed commit.

@aduth
Copy link
Member

aduth commented Apr 2, 2024

@jc-gsa It looks like your "empty commit" d4e19a8 actually reverted the changes from your initial commit, resulting in no changes.

@jc-gsa jc-gsa force-pushed the LG-12759-Update-personal-key-help-article branch from d4e19a8 to d6e4743 Compare April 2, 2024 14:41
@jc-gsa
Copy link
Contributor Author

jc-gsa commented Apr 2, 2024

@aduth Re-added content change. The commit should be signed as well.

aduth
aduth previously approved these changes Apr 2, 2024
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@jc-gsa jc-gsa force-pushed the LG-12759-Update-personal-key-help-article branch from b3b375f to 388a3aa Compare April 2, 2024 16:39
@jc-gsa jc-gsa force-pushed the LG-12759-Update-personal-key-help-article branch from 388a3aa to 8e44007 Compare April 2, 2024 17:03
Signed-off-by: Jack Cody <jack.cody@gsa.gov>
@jc-gsa jc-gsa merged commit e952c00 into main Apr 2, 2024
14 checks passed
@jc-gsa jc-gsa deleted the LG-12759-Update-personal-key-help-article branch April 2, 2024 18:10
mitchellhenke added a commit that referenced this pull request Apr 29, 2024
mitchellhenke pushed a commit that referenced this pull request May 6, 2024
Add personal key content change

Signed-off-by: Jack Cody <jack.cody@gsa.gov>
mitchellhenke pushed a commit that referenced this pull request May 6, 2024
Add personal key content change

Signed-off-by: Jack Cody <jack.cody@gsa.gov>
mitchellhenke pushed a commit that referenced this pull request May 6, 2024
Add personal key content change

Signed-off-by: Jack Cody <jack.cody@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants