Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logic to set href for service link #7524

Merged
merged 7 commits into from
May 20, 2024
Merged

Added logic to set href for service link #7524

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6e4a1cc
Added logic to set href for service link
nick-mon1 Apr 25, 2024
7216143
Simplified logic, added relURL to set the link properly
nick-mon1 Apr 26, 2024
0a8cb94
Merge branch 'main' into nl-fix-link-for-services
nick-mon1 Apr 29, 2024
e92eb9a
Prefer .Permalink for internal links
nick-mon1 Apr 29, 2024
8220a53
Merge branch 'nl-fix-link-for-services' of https://github.com/GSA/dig…
nick-mon1 Apr 29, 2024
50060f4
Merge branch 'main' into nl-fix-link-for-services
ToniBonittoGSA Apr 29, 2024
ee6ab99
Merge branch 'main' into nl-fix-link-for-services
ToniBonittoGSA May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions themes/digital.gov/layouts/services/card-service.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="card-service">
{{/* set the href as a variable */}}
{{- $href := "" -}}
{{- $href := or .Params.source_url .Permalink -}}

{{/* Logos
Get the "source" in the file and looks up the icon that is used there.
Expand All @@ -25,7 +25,7 @@

<div class="copy">
<h2 class="card__title">
<a href="{{- $href -}}" title="{{- .Params.title -}}"
<a href="{{- $href | relURL -}}" title="{{- .Params.title -}}"
>{{- .Params.title -}}</a
>
</h2>
Expand Down
Loading