Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Angular 13) Tooltip Text Icon - Misaligned with the labels #590

Closed
wonko-gsa opened this issue Nov 16, 2022 · 1 comment
Closed

(Angular 13) Tooltip Text Icon - Misaligned with the labels #590

wonko-gsa opened this issue Nov 16, 2022 · 1 comment

Comments

@wonko-gsa
Copy link

wonko-gsa commented Nov 16, 2022

RE: IAEMOD-6641

1. We've updated @gsa-sam packages as below:

    "@gsa-sam/components": "13.0.1",
    "@gsa-sam/sam-formly": "13.0.1",
    "@gsa-sam/sam-material-extensions": "13.0.1",
    "@gsa-sam/sam-styles": "0.0.147",
  • Other @gsa-sam packages info, FYI:
    "@gsa-sam/layout": "13.0.0-beta.1",
    "@gsa-sam/layouts": "13.0.0-beta.0",
    "@gsa-sam/ngx-uswds": "13.0.0-beta.1",
    "@gsa-sam/ngx-uswds-icons": "13.0.0-beta.2",
    "@gsa-sam/shared": "12.0.38",

2. Screenshots:

(In the screenshots, the left side is localhost which is after the packages updated, and the right side is Comp before the update)

2a. Under Exclusions Type, the tooltip icons for Agency Exclusions and My Exclusions looks misaligned:
a exclusions-type-label-pixelized

3. Here is formly config:

3a. For #2a above:

    {
      key: 'requestTypesOptions',
      templateOptions: { group: 'panel' },
      fieldGroup: [
        {
          key: 'requestType',
          id: 'requestType',
          type: 'radio',
          defaultValue: 'myexclusions',
          templateOptions: {
            label: 'Exclusions Type',
            hideOptional: true,
            options: [
              // tslint:disable-next-line: max-line-length
              { label: 'Agency Exclusions', value: 'myagencyexclusions', tooltipText: 'Search results will contain all Agency Exclusions.' },
              { label: 'My Exclusions', value: 'myexclusions', tooltipText: "Search results will contain all your Exclusions." }
            ],
            change: (field, $event) => {
              this.applyFilters(field);
            }
          },
          hooks: {
            onInit: (field: FormlyFieldConfig) => {
              if (this.queryParams.requestType != null) {
                field.formControl.setValue(this.queryParams.requestType);
              }
            }
          }
        }
      ]
    },
@wonko-gsa wonko-gsa changed the title Tooltip Text Icon - Misaligned with the labels (Angular 13) Tooltip Text Icon - Misaligned with the labels Nov 16, 2022
@cwolf10
Copy link
Collaborator

cwolf10 commented Dec 15, 2022

Resolved with #594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants