SRCH-1873 install and configure the searchgov_style gem #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops - force-pushing to correct the Jira ticket #. |
- autocorrect some Rubocop offenses in specs
MothOnMars
force-pushed
the
searchgov_style_1873
branch
from
0d738ca
to
cf1f53f
Compare
MothOnMars
changed the title
Merged
Merged
MyNameIsMissing
added a commit
that referenced
this pull request
Mar 23, 2021
Functional SRCH-1772 validate RoutedQuery#url (#670) SRCH-1915 fix Tweet.expire method (#671) Spec/Test only updates SRCH-1926 update CircleCi config to use updated ruby 2.5.5 image (#665) SRCH-1873 install and configure the searchgov_style gem (#667) SRCH-1552 address cucumber logout tests. (#666) SRCH-1982 merge "IgnoredMethods" in Rubocop config (#673)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
rubocopwith our sharedsearchgov_stylegem. It also includes changes made by autocorrecting several types of Rubocop offenses (in separate commits for clarity). This does not address the full set of autocorrectable offenses; this PR includes some timeboxed, low-hanging fruit-type changes.This PR is expected to fail CodeClimate; I will manually approve the offenses, which will all be pre-existing.