Logout tests.

[jmax-fearless]

The RuboCop comment in user_sessions_controller_spec.rb could be replaced by an exclusion in the appropriate config file, since it's disabling the ScatteredSetup cop for the whole file. I judged it better to use the pseudo-comment facility, because the exclusion results from what the specs are doing, rather than from the type (system, controller, etc.) of the spec.

[MothOnMars]

@jmax-fearless , please update the commit message to include the ticket #

[jmax-fearless]

@MothOnMars - Updated.

[MothOnMars]

A few changes. For clarity, the full spec with the changes I'm suggesting would look like:

describe UserSessionsController do
  before { activate_authlogic }
  
  # remove additional `before { activate_authlogic }` blocks
...
  describe '#destroy' do
    subject(:destroy) { delete :destroy }

    let(:login_uri) { "#{request.protocol}#{request.host_with_port}/login" }
    let(:id_token) { 'fake_id_token' }
    let(:expected_login_dot_gov_logout_uri) do
      URI::HTTPS.build(
        host: 'idp.int.identitysandbox.gov',
        path: '/openid_connect/logout',
        query: {
          id_token_hint: id_token,
          post_logout_redirect_uri: login_uri,
          state: '1234567890123456789012'
        }.to_query
      ).to_s
    end

    before { session[:id_token] = id_token }

    include_context 'approved user logged in'

    it { is_expected.to redirect_to(expected_login_dot_gov_logout_uri) }
  end
end

[MothOnMars]

use the method in the description: describe '#destroy'

[jmax-fearless]

Changed description to use the method name.

[jmax-fearless]

@MothOnMars - All comments have been addressed. Please re-review at your convenience.

[MothOnMars]

LGTM. As changes are test-only, you may merge without further ado.