Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRCH-2221 Remove Ruby 2.5 from search-gov CircleCI #724

Merged
merged 1 commit into from
May 12, 2021
Merged

SRCH-2221 Remove Ruby 2.5 from search-gov CircleCI #724

merged 1 commit into from
May 12, 2021

Conversation

jmax-fearless
Copy link
Contributor

Also added a nice name display for the matrixed build versions.

@jmax-fearless
SRCH-2221 Remove Ruby 2.5 from search-gov CircleCI
f3b13b6 
Also added a nice name display for the matrixed build versions.
MothOnMars
MothOnMars approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@MothOnMars MothOnMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmax-fearless jmax-fearless merged commit 3cbd2b0 into GSA:master May 12, 2021
@MyNameIsMissing MyNameIsMissing mentioned this pull request May 25, 2021
Merged
MyNameIsMissing added a commit that referenced this pull request May 25, 2021
@MyNameIsMissing
Release 3.0.0
da86f93 
SRCH-2150 remove legacy "advanced" header/footer (#726)
SRCH-2255 lock execjs to 2.7.x (#725)
SRCH-2221 Remove Ruby 2.5 from search-gov CircleCI (#724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MothOnMars MothOnMars MothOnMars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmax-fearless @MothOnMars