Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRCH-2150 remove legacy "advanced" header/footer #726

Merged
merged 1 commit into from
May 18, 2021

Conversation

MothOnMars
Copy link
Contributor

@MothOnMars MothOnMars commented May 14, 2021

SRCH-2150 remove legacy "advanced" header/footer

  • remove admin center controls for the advanced header/footer
  • bump simplecov
  • remove unused gems
  • bundle update gems

@MothOnMars MothOnMars force-pushed the managed_2150 branch 3 times, most recently from 995a430 to 748d202 Compare May 14, 2021 16:39
@MothOnMars MothOnMars changed the title Managed 2150 SRCH-2150 remove legacy "advanced" header/footer May 14, 2021
- remove admin center controls for the advanced header/footer
- bump simplecov
- remove unused gems
- bundle updated gems
@MothOnMars MothOnMars marked this pull request as ready for review May 14, 2021 19:29
@MothOnMars
Copy link
Contributor Author

@jmax-fearless , this is ready for review. The two CC failures are pre-existing issues.

Copy link
Contributor

@jmax-fearless jmax-fearless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MothOnMars MothOnMars merged commit 5df77b2 into GSA:master May 18, 2021
@MothOnMars MothOnMars deleted the managed_2150 branch May 18, 2021 15:02
@MyNameIsMissing MyNameIsMissing mentioned this pull request May 25, 2021
MyNameIsMissing added a commit that referenced this pull request May 25, 2021
SRCH-2150 remove legacy "advanced" header/footer (#726)
SRCH-2255 lock execjs to 2.7.x (#725)
SRCH-2221 Remove Ruby 2.5 from search-gov CircleCI (#724)
MothOnMars added a commit to MothOnMars/search-gov that referenced this pull request Aug 2, 2021
- remove admin center controls for the advanced header/footer
- bump simplecov
- remove unused gems
- bundle updated gems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants