SRCH-2453 verify host when connecting to Twitter's streaming API #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bundle updated gems
jmax-fearless
approved these changes
Aug 24, 2021
| @@ -78,7 +81,7 @@ gem 'retry_block', '~> 1.2.0' | |||
| gem 'aws-sdk', '< 3.0' | |||
| gem 'colorize', '~> 0.8.1' | |||
| gem 'dogstatsd-ruby', '~> 3.2.0' | |||
| gem 'http', '~> 1.0' | |||
| gem 'http', '~> 4.0' | |||
|
@jmax-fearless , re-review requested for config tweak: |
MyNameIsMissing
added a commit
that referenced
this pull request
Sep 2, 2021
Functional SRCH-2324 update newrelic_rpm (SRCH-2324 update newrelic_rpm #771) … SRCH-2453 verify host when connecting to Twitter's streaming API (SRCH-2453 verify host when connecting to Twitter's streaming API #769) … Testing or Process SRCH-2457 add pull request template (SRCH-2457 add pull request template #774) SRCH-2110 consolidate cucumber tests (SRCH-2110 consolidate cucumber tests #773)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we validate the host when connecting to Twitter's streaming API via the
tweetstreamgem. This resolves the "Improper Certificate Validation in TweetStream" vulnerability.