Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRCH-2457 add pull request template #774

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

MothOnMars
Copy link
Contributor

@MothOnMars MothOnMars commented Aug 26, 2021

Summary

This PR adds a Github PR template.

Checklist

Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review:

Functionality Checks

  • Code is functional.

  • Automated checks pass, if applicable. If Code Climate checks do not pass, explain reason for failures:

  • If your changes will be tested manually, you have run bundle update and committed your changes to Gemfile.lock. - N/A

  • You have merged the latest changes from the target branch (usually master or main) into your branch.

  • If your target branch is NOT master or main, specify the reason:

  • PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release #.#.# matching the release number

  • You have squashed your commits into a single commit (exception: your PR includes commits with formatting-only changes, such as required by Rubocop)

  • Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket

Process Checks

  • You have specified an "Assignee", and if necessary, additional reviewers

Copy link
Contributor

@jmax-fearless jmax-fearless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MothOnMars MothOnMars merged commit a3ac1ae into GSA:master Aug 27, 2021
@MothOnMars MothOnMars deleted the pr_template_2457 branch August 27, 2021 14:49
@MyNameIsMissing MyNameIsMissing mentioned this pull request Sep 2, 2021
9 tasks
MyNameIsMissing added a commit that referenced this pull request Sep 2, 2021
Functional
SRCH-2324 update newrelic_rpm (SRCH-2324 update newrelic_rpm #771) …
SRCH-2453 verify host when connecting to Twitter's streaming API (SRCH-2453 verify host when connecting to Twitter's streaming API #769) …
Testing or Process
SRCH-2457 add pull request template (SRCH-2457 add pull request template #774)
SRCH-2110 consolidate cucumber tests (SRCH-2110 consolidate cucumber tests #773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants