SRCH-2110 consolidate cucumber tests #773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates and consolidates our cucumber tests for searches, following the deprecation of the legacy SERP. I have left the original feature file in place to maintain the git history of the tests, but left warning comments for future tests. The VCR cassettes will be updated in a subsequent story.
Checklist
Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review:
Functionality Checks
Code is functional: changes are test-only
Automated checks pass, if applicable. If Code Climate checks do not pass, explain reason for failures:
If your changes will be tested manually, you have run
bundle update
and committed your changes to Gemfile.lock. - N/AYou have merged the latest changes from the target branch (usually
master
ormain
) into your branch.If your target branch is NOT
master
ormain
, specify the reason:PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release #.#.# matching the release number
You have squashed your commits into a single commit (exception: your PR includes commits with formatting-only changes, such as required by Rubocop)
Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket
Process Checks