Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try switching to Jodit #15

Closed
GWBasic opened this issue Jan 7, 2021 · 3 comments · Fixed by #18 or #23
Closed

Try switching to Jodit #15

GWBasic opened this issue Jan 7, 2021 · 3 comments · Fixed by #18 or #23
Labels
enhancement New feature or request

Comments

@GWBasic
Copy link
Owner

GWBasic commented Jan 7, 2021

Throughout developing z3, I've found it difficult to work with CKEditor.

In this ticket: Try switching to Jodit: https://xdsoft.net/jodit/. Jodit contains a WYSIWYG mode that, in theory, should fix #5

Alternatively, try Quill: https://quilljs.com/

@GWBasic
Copy link
Owner Author

GWBasic commented Jan 7, 2021

In progress on branch 15_TryJodit

TODOs:

  • Better resize the editor. It should be within a box with a scrollbar
  • Upload images

@GWBasic GWBasic added enhancement New feature or request in_progress labels Jan 11, 2021
@GWBasic
Copy link
Owner Author

GWBasic commented Jan 13, 2021

Almost complete, TODOs:

  • Clean up code
  • Fix the size of the editor so it always fills the screen, even when the text is short

@GWBasic GWBasic linked a pull request Jan 13, 2021 that will close this issue
@GWBasic
Copy link
Owner Author

GWBasic commented Jan 13, 2021

Reopened because of failing tests

@GWBasic GWBasic reopened this Jan 13, 2021
@GWBasic GWBasic linked a pull request Jan 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant