Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers for checking proof obligations #1215

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

langston-barrett
Copy link
Contributor

@langston-barrett langston-barrett self-assigned this Jun 18, 2024
@langston-barrett
Copy link
Contributor Author

This PR moves in the direction of deduplicating code that proves goals. In the future, it would be nice to improve these helpers by:

  • Allowing "fast failure" on conjunctions of goals (i.e., not attempting to prove the RHS if the LHS is disproved)
  • Parallelization and timeouts of solver queries (see the ambient-verifier link above)
  • Use of push/pop in an online solver, rather than distributing assumptions into goals

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice cleanup. I only have minor suggestions.

crucible/src/Lang/Crucible/Backend/Prove.hs Outdated Show resolved Hide resolved
crucible/src/Lang/Crucible/Backend/Prove.hs Outdated Show resolved Hide resolved
crucible/src/Lang/Crucible/Backend/Prove.hs Outdated Show resolved Hide resolved
crucible/src/Lang/Crucible/Backend/ProofGoals.hs Outdated Show resolved Hide resolved
crucible/src/Lang/Crucible/Backend/Prove.hs Outdated Show resolved Hide resolved
crucible/src/Lang/Crucible/Backend/Prove.hs Outdated Show resolved Hide resolved
crucible/src/Lang/Crucible/Backend/Prove.hs Outdated Show resolved Hide resolved
@langston-barrett langston-barrett merged commit 19e9a52 into GaloisInc:master Jun 20, 2024
32 checks passed
@langston-barrett langston-barrett deleted the lb/prove-goals branch June 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants