Fix two minor CI artifact issues discovered during SAW 1.0 release #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is worthwhile to pin the version number explicitly since: 1. The `windows-latest` alias could change at any time, so pinning the version avoids unwanted breakages that arise from new OS versions. 2. The name "`windows-latest`" leaks into bindist names, which doesn't look as nice as using the name "`windows-2019`". We use `windows-2019` instead of `windows-2022` for now, since that is what `what4-solvers` currently uses.
|
The artifacts look much better now:
|
kquick
approved these changes
Jun 30, 2023
RyanGlScott
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: Pin to windows-2019 instead of windows-latest
It is worthwhile to pin the version number explicitly since:
The
windows-latestalias could change at any time, so pinning the version avoids unwanted breakages that arise from new OS versions.The name "
windows-latest" leaks into bindist names, which doesn't look as nice as using the name "windows-2019".We use
windows-2019instead ofwindows-2022for now, since that is whatwhat4-solverscurrently uses.CI: Put solver bindists in separate artifact from non-solver bindists
Fixes #1884.