Fix global variable example in manual #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the following modifications to the global variable example in the SAW manual to get it to verify: 1. Adds an `llvm_alloc_global` call to `init_global`. Without this, the proof fails with "Global symbol not allocated". 2. Adds a precondition: `y < 2^^31 - 1`. Without this, the proof fails due to a potential overflow from `x + y` when `y` is `INT_MAX`.
RyanGlScott
approved these changes
Jul 7, 2023
Co-authored-by: Ryan Scott <rscott@galois.com>
bboston7
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the following modifications to the global variable example in the SAW manual to get it to verify:
llvm_alloc_globalcall toinit_global. Without this, the proof fails with "Global symbol not allocated".y < 2^^31 - 1. Without this, the proof fails due to a potential overflow fromx + ywhenyisINT_MAX.