add choice between 'pretty' or 'json' summary #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing because the CI uses ghc-8.6.5 and the bytestring package is pinned to 0.10.8.2 in cabal.GHC-8.6.5.config and jsonifier needs >= 0.10.10 |
nano-o
force-pushed
the
json_summary_2
branch
from
5c72cbe
to
3d4b2f8
Compare
nano-o
force-pushed
the
json_summary_2
branch
2 times, most recently
from
c95da4a
to
db9aae8
Compare
Couldn't get the build working with Jsonifier and ghc-8.6.5 (pulled in too recent a version of bytestring)
nano-o
force-pushed
the
json_summary_2
branch
from
db9aae8
to
28e58e3
Compare
hazelweakly
approved these changes
Dec 14, 2020
| @@ -74,66 +83,77 @@ printOutWith setting level msg | |||
| printOutLn :: Options -> Verbosity -> String -> IO () | |||
| printOutLn o v s = printOutFn o v (s ++ "\n") | |||
|
|
|||
| options :: [OptDescr (Options -> Options)] | |||
| options :: [OptDescr (Options -> IO Options)] -- added IO to do validation here instead of later | |||
There was a problem hiding this comment.
At some point we might want to switch to a "real" option parsing library so that we can handle things like defaults, option groups, better validation, and useful error messages in a more principled way.
This seems fine to me for now, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to produce a verification summary in JSON format, as needed by @jared-w