Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoind for onchain #317

Closed
wants to merge 38 commits into from
Closed

Bitcoind for onchain #317

wants to merge 38 commits into from

Commits on Jul 9, 2021

  1. Adding temporary bitcoindHotWalletClient

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    d7b3016 View commit details
    Browse the repository at this point in the history

  2. Starting to add bitcoind functions that will replace lnd equivalents … 

    …(TODO: estimateSmartFee is not working yet)
    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    91efc67 View commit details
    Browse the repository at this point in the history

  3. Bitcoind sendToAddress is in BTC

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    d65b6b0 View commit details
    Browse the repository at this point in the history

  4. Getting the fee from getTransaction directly

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    f25b124 View commit details
    Browse the repository at this point in the history

  5. Logs showing most of bitcoind values working (tests pass)

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    e2a4b73 View commit details
    Browse the repository at this point in the history

  6. Revert "Logs showing most of bitcoind values working (tests pass)" 

    This reverts commit e2a4b73.
    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    4055d24 View commit details
    Browse the repository at this point in the history

  7. Prettier modifications

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    b2cb90b View commit details
    Browse the repository at this point in the history

  8. Disable unused variable warning

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    f892602 View commit details
    Browse the repository at this point in the history

  9. Use bitcoindHotWalletClient instead of bitcoindDefaultClient

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    efa79b6 View commit details
    Browse the repository at this point in the history

  10. Keep imports in alphabetical order

    @jotapea
    jotapea committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    f53c0e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Add (temporary?) PayOnChainClient class 

    - Encapsulates variation between onchain clients
- LndOnChainClient class implements the original lnd-onchain calls
- This class may be temporary, but it is currently useful to switch between lnd and bitcoind in one line
    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    722eaac View commit details
    Browse the repository at this point in the history

  2. Add BitcoindClient class and one line switch 

    - TODO: getEstimatedFee method is not working yet
- The tests start to fail...
    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    b42e713 View commit details
    Browse the repository at this point in the history

  3. Switch back to lnd client

    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    846163a View commit details
    Browse the repository at this point in the history

  4. Comments of failed bitcoind tests

    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    eaae5d9 View commit details
    Browse the repository at this point in the history

  5. Removing try catch from test

    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    c9f5023 View commit details
    Browse the repository at this point in the history

  6. Name the default bitcoind wallet 'default'

    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    931930a View commit details
    Browse the repository at this point in the history

  7. Prettier

    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    7a8c996 View commit details
    Browse the repository at this point in the history

  8. Adding test to funding new hot wallet fails 

    The equivalent test for the default wallet passes
    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    d2b9993 View commit details
    Browse the repository at this point in the history

  9. Comment out failing test

    @jotapea
    jotapea committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    f191f71 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Rename default test and remove hot wallet

    @jotapea
    jotapea committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    2195777 View commit details
    Browse the repository at this point in the history

  2. Rename test from fund bitcoind to outside

    @jotapea
    jotapea committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7b3014d View commit details
    Browse the repository at this point in the history

  3. Rename onchain_funding to lnd_onchain_funding

    @jotapea
    jotapea committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    d75007f View commit details
    Browse the repository at this point in the history

  4. Add test that creates hot bitcoind wallet 

    And using it in OnChain:BitcoindClient
    @jotapea
    jotapea committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    74cc217 View commit details
    Browse the repository at this point in the history

  5. One more location to set the "default" wallet

    @jotapea
    jotapea committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    5e85a45 View commit details
    Browse the repository at this point in the history

  6. Tests pass deposit to bitcoind test commented out

    @jotapea
    jotapea committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ddcef66 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Add bitcoind client version of onchain methods

    @jotapea
    jotapea committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    2ff75ba View commit details
    Browse the repository at this point in the history

  2. Add alternate bitcoind_onchain_funding function

    @jotapea
    jotapea committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    f5403dc View commit details
    Browse the repository at this point in the history

  3. Enable bitcoind client and funding tests TODO 

    - The funding tests now pass
- But the checkIsBalanced starts failing after crediting lnd tests (TODO)
    @jotapea
    jotapea committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    0d34550 View commit details
    Browse the repository at this point in the history

  4. Revert "Enable bitcoind client and funding tests TODO" 

    This reverts commit 0d34550.
    @jotapea
    jotapea committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    a5d0433 View commit details
    Browse the repository at this point in the history

  5. Fix: Define type for transactions_bitcoind

    @jotapea
    jotapea committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    cdb2130 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Onchain receive test passes 

    But the rest of the tests don't
    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    8c2c32d View commit details
    Browse the repository at this point in the history

  2. Temporary removal

    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    3137c35 View commit details
    Browse the repository at this point in the history

  3. Revert "Temporary removal" 

    This reverts commit 3137c35.
    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    a88636e View commit details
    Browse the repository at this point in the history

  4. Rename class avoid conflict with BitcoindClient

    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    9eed585 View commit details
    Browse the repository at this point in the history

  5. Rename 'default' wallet to 'outside'

    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    2daa2dc View commit details
    Browse the repository at this point in the history

  6. Rename to bitcoindHotWalletClient

    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    2d47cb9 View commit details
    Browse the repository at this point in the history

  7. Keep default bitcoind client while having outside 

    Instead of just replacing the default client with the outside client,
it seems appropriate to still keep a default client around for non-
wallet bitcoin-node specific functionality
    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    d20f6de View commit details
    Browse the repository at this point in the history

  8. Temporary remove

    @jotapea
    jotapea committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    038be28 View commit details
    Browse the repository at this point in the history