Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail in a controlled manner when configuring Cubos improperly #1266

Closed
RiscadoA opened this issue Jun 18, 2024 · 1 comment
Closed

Fail in a controlled manner when configuring Cubos improperly #1266

RiscadoA opened this issue Jun 18, 2024 · 1 comment

Comments

@RiscadoA
Copy link
Member

Problem

Currently the Cubos class methods abort in case of configuration inconsistencies/errors, e.g., due to registering a component twice, or missing a plugin dependency.
This is a problem when loading applications into Tesseratos - if a buggy/incomplete game is loaded into the editor and run, it could crash the editor itself, and the dev may lose work.

Solution

The Cubos class should hold a 'failed' flag or something similar. When it fails, it logs an error, and sets the flag, making all further operations do nothing.
Then we should have a method to check whether the app is in a valid state.
If run is called even with an invalid app, abort should be called.

@RiscadoA RiscadoA added this to the 0.4 - ??? milestone Jun 18, 2024
@RiscadoA RiscadoA removed this from the 0.4 - ??? milestone Aug 8, 2024
@RiscadoA
Copy link
Member Author

RiscadoA commented Aug 8, 2024

No longer applies with new editor design

@RiscadoA RiscadoA closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant