Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PointWave] Reset button does not work after manually changing position of source #498

Open
FlorianGlawogger opened this issue Jul 25, 2024 · 1 comment · May be fixed by #535
Open

[PointWave] Reset button does not work after manually changing position of source #498

FlorianGlawogger opened this issue Jul 25, 2024 · 1 comment · May be fixed by #535
Assignees
Labels
defect Broken feature or bug

Comments

@FlorianGlawogger
Copy link
Collaborator

Describe the defect
The waves in the PointWave experiment do not originate from the source under certain preconditions (see next section)

To Reproduce
Steps to reproduce the behavior:

  1. Go to PointWave experiment
  2. Click on 'Add Source'
  3. Move source with the mouse to somewhere, e.g. middle of the experiment water pool
  4. In the top right, change source position to something different, e.g. 1.00 & 1.00
  5. Click on the double arrow back (reset simulation button, to the left of the play button)
  6. Source now appears to move to the previous position where it has been dragged to with the mouse, but if you now press 'Play', the waves originate from the manual position that was in the top right corner for example

Expected behavior
Not sure how the experiment was intended to work, either I expect all sources to be deleted anyway, or if the previous mouse position really is to be used, then the waves should also originate from that position.

Found in version
develop branch, 92fd345

Screenshots
waves do not originate from the source, but from the position where the source was before pressing the reset simulation button
grafik

Desktop (please complete the following information):

  • OS: Windows
  • Version 11

Additional context

@FlorianGlawogger FlorianGlawogger added the defect Broken feature or bug label Jul 25, 2024
@FlorianGlawogger FlorianGlawogger self-assigned this Oct 23, 2024
@FlorianGlawogger
Copy link
Collaborator Author

Furthermore:

  • The color sliders are not reset correctly (also at the start of the experiment)
  • Reset also should reset the top right delete/add source correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Broken feature or bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant