Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procgen tests could stress outputs harder? #45

Open
Gankra opened this issue Jul 1, 2024 · 0 comments
Open

procgen tests could stress outputs harder? #45

Gankra opened this issue Jul 1, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@Gankra
Copy link
Owner

Gankra commented Jul 1, 2024

Right now in procgen we only end up emitting a couple tests that shove the type of interest in the output, or, literally anything in the output.

abi-cafe/src/procgen.rs

Lines 29 to 32 in dd37470

if !has_refs {
add_func(out, "val_out", &[], &[ty])?;
add_func(out, "val_in_out", &[ty], &[ty])?;
}

There's only so much you can do with Rust and C being our primary languages, given multiple returns don't exist and outparams aren't really outputs abi-wise (and i've consequently refused to reimplement their tedium).

We could generate two copies of each function (one with output, one without). We could generate a struct containing multiple values to return. There's options here, but idk how hard we want to push on it, or which abi exhaustion conditions we're pushing on.

@Gankra Gankra added enhancement New feature or request question Further information is requested help wanted Extra attention is needed labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant