Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feel free to tell your problems in this place! #10

Open
GarinZ opened this issue Mar 22, 2023 · 13 comments
Open

Feel free to tell your problems in this place! #10

GarinZ opened this issue Mar 22, 2023 · 13 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@GarinZ
Copy link
Owner

GarinZ commented Mar 22, 2023

Link Map is still in its early version, so you may encounter some 'unique' issues while using it. But feel free to provide feedback here in your own way.

About Language of Questions: English is the first recommended language, but you can ask in your native language and please provide an English translation for everyone to refer to.


Link Map仍处于早期版本,因此在使用过程中可能会遇到一些“独特”的问题。但是您可以在此自由反馈,以您的方式提供反馈意见。
关于提问的语言:英语是第一推荐语言,你可以使用自己本地的语言提问,但请也提供英语版本的翻译以供大家查阅

@GarinZ GarinZ added the good first issue Good for newcomers label Mar 22, 2023
@GarinZ GarinZ pinned this issue Mar 22, 2023
@GarinZ GarinZ changed the title Feel free to tell your problems in this Place! Feel free to tell your problems in this place! Mar 22, 2023
@iPeng6
Copy link

iPeng6 commented Mar 22, 2023

Can it be automatically grouped according to the site?
可以根据站点自动分组么?

@GarinZ
Copy link
Owner Author

GarinZ commented Mar 23, 2023

Can it be automatically grouped according to the site?

可以根据站点自动分组么?

Hi @iPeng6

Could you please describe the site grouping function in detail? This will help me understand your needs.
Is the site automatically grouped according to the domain, they are automatically mounted under a node, correct me if I understand wrong.
In addition, if there are products that provide similar functions, you can also tell me, so as to be an intuitive reference

可以麻烦你描述一下站点分组功能的细节嘛?这可以帮助我理解你的需求。
是不是根据站点的主域名进行自动分组并把它们自动放在到一个节点下面,如果我理解的不对可以纠正我。
另外如果有产品提供了类似的功能可以也告诉我,便于作为直观的参考

@GarinZ GarinZ self-assigned this Mar 23, 2023
@iPeng6
Copy link

iPeng6 commented Mar 23, 2023

Yes, automatically group by main domain name, eg: *.example.com/* they all count as one group
是的,自动按照主域名分组,例如: *.example.com/* 它们都算一个分组

@XingyanMao
Copy link

Can it be automatically grouped according to the site?
可以根据站点自动分组么?

Hi @iPeng6

Could you please describe the site grouping function in detail? This will help me understand your needs. Is the site automatically grouped according to the domain, they are automatically mounted under a node, correct me if I understand wrong. In addition, if there are products that provide similar functions, you can also tell me, so as to be an intuitive reference

可以麻烦你描述一下站点分组功能的细节嘛?这可以帮助我理解你的需求。 是不是根据站点的主域名进行自动分组并把它们自动放在到一个节点下面,如果我理解的不对可以纠正我。 另外如果有产品提供了类似的功能可以也告诉我,便于作为直观的参考

类似的插件有acid tabs

@Find7z
Copy link

Find7z commented Mar 30, 2023

有几个问题:

  1. 在popup页面删除一个window,是否应该将下面的tab一起删除,或者能提供一个设置项,能配置删除window时一起删除下面的tab
  2. 能提供选中多个tab的功能?有时想关闭、删除、拖动一部分tab的时候,必须一个一个操作
  3. 每删除一个tab的时候,你的整颗树会上下移动位置,导致想连续删除多个tab的时候,每删除一个tab,都要去移动一下树去定位原来删除的位置
  4. 在mac电脑这边,重启电脑,它能自动打开原来的应用并恢复到重启前的样子,包括重启前打开的所有浏览器tab,这就导致重启后popup的树里面出现很多重复的页面,可能是重启后系统恢复的tab的id不一样了 ,你的插件认为是新的页面?
  5. 你的快捷键图标会挡住最后一个tab的关闭按钮
  6. 能否提供popup页面中树的节点全部折叠的快捷键或者按钮
  7. 快捷键能否是自己可设置的
  8. 会和Tab Suspender这样的插件产生兼容性问题,Tab Suspender这些插件会将打开但一段时间没点击的tab用自己的url替换,以释放占用内存,并没有关闭tab和创建新tab,但你的插件会认为是新的tab产生原来tab被关闭了?从而导致popup树中出现了重复tab

There are a few questions:

  1. When deleting a window on the popup page, should the tabs below be deleted together, or can a setting item be provided to configure the tabs below to be deleted together when the window is deleted?
  2. Can you provide the function of selecting multiple tabs? Sometimes when you want to close, delete, or drag some tabs, you must operate one by one
  3. Every time you delete a tab, your entire tree will move up and down, so when you want to delete multiple tabs in a row, you have to move the tree to locate the original deleted position every time you delete a tab
  4. On the mac computer side, restart the computer, it can automatically open the original application and restore it to the state before the restart, including all the browser tabs opened before the restart, which leads to many duplicate pages in the popup tree after the restart , it may be that the id of the tab restored by the system is different after restarting, and your plug-in thinks it is a new page?
  5. Your shortcut icon will block the close button of the last tab
  6. Can you provide a shortcut key or button to collapse all the nodes of the tree in the popup page
  7. Whether the shortcut key can be set by yourself
  8. There will be compatibility issues with plug-ins such as Tab Suspender. These plug-ins of Tab Suspender will replace tabs that have been opened but have not been clicked for a period of time with their own urls to release memory. They do not close tabs and create new tabs, but you The plug-in will think that the new tab is generated and the original tab is closed? As a result, duplicate tabs appear in the popup tree

@GarinZ
Copy link
Owner Author

GarinZ commented Mar 31, 2023

Hi @Find7z ,
感谢你的反馈,以下是我的回复。
Q1: Window节点删除时应该删除所有子Tab
Link Map对于Window节点删除的操作有以下方式:

  1. 对于已经打开的Window,选择Window节点并点击删除的时候会删除所有打开的子Tab,但保留所有处于关闭状态的Tab(主要考虑避免误删想要保存的Tab)。请见第一张图片
  2. 对于已经关闭并保存的窗口,点击删除Window节点的时候只会删除Window节点。
  3. 收起Window/Tab节点,并点击删除,可以删除当前节点和所有子节点(通过这种方法可以强制删除所有子节点),请见第二张图片。

但在下一个版本中我应该会在右键菜单中增加一个“删除当前节点及其子节点”的选项。
Q2:支持多选Tab
对多选Tab的支持我也收到了其他用户的反馈,我会仔细考虑这个功能,但它有一定的实现难度我可能会将它放在稍后一点的迭代中进行开发。
对于现阶段的Link Map,目前的批量操作Tab的方式,可以通过Q1问题的第3种方式,先把Tab拖拽成一个子树-收起父节点-点击删除。可能还是会有一些麻烦,但目前这确实是最快的方法。
Q3:删除时树会上下移动
这确实是个问题,我会在下个版本立刻优化
Q4:浏览器重新打开后,历史的Window和Tab节点不会进行映射,而是重新创建子树
这是一个我没有来得及解决的问题,正如你所说,浏览器重新打开时Window/Tab都是新的id,所以导致了现在的情况。
我尝试了几种方案都在边界case上会映射错误,当找到好的方案时我会立刻优化这个问题。
Q5:快捷键挡住按钮组
可恶,我居然没发现,我会下个版本立刻修复
Q6:增加全部收起/展开按钮
没问题,这个功能很有用,下个版本就加上
Q7:自定义快捷键
这个功能一定会加入,由于开发时间问题,我可能会把它放在稍后一点的版本中
Q8:与Tab Suspender的兼容问题
我没有用过Tab Suspender,所以我可能需要时间稍稍研究一下。但如果这个扩展处理的方式太过hack,解决这个问题可能有些困难。


Thank you for your feedback, here's my response.
Q1: Deleting a Window node should delete all child Tabs
Link Map offers the following options when deleting a Window node:
For open Windows, selecting and deleting a Window node will delete all open child Tabs but keep all closed Tabs (to prevent accidentally deleting Tabs that users want to save). Please refer to the first image.
For closed and saved windows, deleting a Window node will only delete the Window node.
Collapsing the Window/Tab node and then deleting it will delete the current node and all child nodes (this method can be used to force delete all child nodes). Please refer to the second image.
However, I will add an option to the right-click menu in the next version to "delete the current node and its child nodes."
Q2: Support for selecting multiple Tabs
I have received feedback from other users regarding support for selecting multiple Tabs. I will carefully consider this feature, but it has some implementation difficulties and may be developed in a later iteration.
For the current version of Link Map, the batch operation of Tabs can be accomplished by using the third method of Q1, by dragging the Tabs into a subtree, collapsing the parent node, and then deleting it. It may still be a bit cumbersome, but it is currently the fastest method.
Q3: Tree moves up and down when deleting
This is indeed a problem, and I will optimize it in the next version immediately.
Q4: When reopening the browser, the history of Window and Tab nodes is not mapped, but a new subtree is created
This is a problem I have not had time to solve. As you said, when the browser is reopened, the Window/Tab IDs are new, which leads to the current situation.
I have tried several solutions, but they all have mapping errors in boundary cases. When I find a good solution, I will optimize this problem immediately.
Q5: Keyboard shortcuts block the button group
Oops, I didn't notice that. I will fix it in the next version immediately.
Q6: Add a button to collapse/expand all
No problem, this feature is very useful, and I will add it in the next version.
Q7: Custom keyboard shortcuts
This feature will definitely be added. Due to development time constraints, I may add it in a later version.
Q8: Compatibility issues with Tab Suspender
I haven't used Tab Suspender, so I may need some time to study it. However, if the way this extension handles things is too hacky, solving this problem may be difficult.

@GarinZ
Copy link
Owner Author

GarinZ commented Apr 7, 2023

@Find7z
Link Map在Chrome Web Store上已经发布了最新版本,Edge的仍在审核中、
Q1. 在最新版本中删除子节点的选项我已经添加到了右键的下拉菜单中
Q3.删除时树会上下移动:这个问题我已经修复啦
Q5.快捷键挡住按钮组:这个问题我已经修复啦
Q6.增加全部收起/展开按钮:我已经分别在顶部栏和右键菜单中分别加入了收起/展开的功能,一个是作用于整个树,一个是作用于一个节点

关于你的其他反馈我也会按照优先级逐步推进,希望你能喜欢Link Map.


The latest version of Link Map has been released on Chrome Web Store, while Edge's is still under review,
Q1. In the latest version, I have added the option to delete child nodes to the context-menu
Q3. The tree moves up and down when deleting: I've fixed this problem.
Q5. Shortcut keys blocking the button group: I've fixed this problem.
Q6. Add all the put away/expand buttons: I have added the put away/expand function to the top bar and right click menu respectively, one for the whole tree and one for a node

About your other feedback I will also follow the priority step by step, I hope you can enjoy Link Map.

@bianwenbo
Copy link

bianwenbo commented May 21, 2023

After folding, a node with a leaf node is visually very similar to a normal node without a leaf node, especially in dark mode, it is difficult to quickly distinguish whether a node has child nodes or not. It is recommended to update the UI to improve differentiation. Personally, I recommend removing the filled circles in the leaf node boxes.

————
折叠后,有叶子节点的节点在视觉上与没有叶子节点的普通节点非常相似,尤其是在暗模式下,很难快速区分节点是否有子节点。 建议更新 UI 以提高差异化。 就个人而言,我建议删除叶节点框中的实心圆圈。

Add Image:
image

For reference, here is the solution used by the tabs outliner.
image

@GarinZ
Copy link
Owner Author

GarinZ commented May 22, 2023

Hi @bianwenbo,
Thanks for your feedback!
In previous versions of Link Map, there is no solid circle icon before nodes without children, and when I first started developing Link Map I thought this placeholder icon in Tabs Outliner was a bit redundant. Later I found that if I set indentation guide lines for nodes without children without this placeholder icon, it would make the interface a bit confusing and the overall indentation arrangement would not be so neat.
The Tabs Outliner will also set the drag indicator according to this placeholder icon when dragging and dropping, and Link Map will do similar optimization in future versions.

Regarding the visual difficulty in distinguishing the placeholder icon from the expanded icon when the node is collapsed, I will make UI optimization for this. You will see this in a later release.


感谢你的反馈!
在Link Map之前的版本中确实是没有这个实心圆圈的,在我一开始开发Link Map的时候我认为Tabs Outliner中这个占位图标是有些多余的。后来我发现如果没有没有这个占位图标情况下再为没有children的节点设置缩进引导线就会让界面有些混乱,整体的缩进排列也会不那么整齐 。
Tabs Outliner在拖拽时,也会根据这个占位图标设置拖拽指示器。Link Map在之后的版本中也会做类似的优化。

关于节点收起后视觉上很难区分占位图标和展开图标的问题,我会对此进行UI上的优化。你会在稍后的版本中看到。

@Cleroth
Copy link

Cleroth commented Jun 2, 2023

Could you provide Sponsorship system on Github or a way for us to support this project by more than just $8? :)

@neiljdo
Copy link

neiljdo commented Aug 15, 2023

Hi @GarinZ, thank you for your work on the plugin!

I'm not sure if this should be the standard behavior but when I close a tab from the browser, shouldn't the plugin just close it (i.e. it gets saved in the tree) for future access instead of deleting it completely?

@Cleroth
Copy link

Cleroth commented Aug 24, 2023

@neiljdo Forget it. This thing is dead already.

@sandriaas
Copy link

sandriaas commented Jan 25, 2024

After folding, a node with a leaf node is visually very similar to a normal node without a leaf node, especially in dark mode, it is difficult to quickly distinguish whether a node has child nodes or not. It is recommended to update the UI to improve differentiation. Personally, I recommend removing the filled circles in the leaf node boxes.

———— 折叠后,有叶子节点的节点在视觉上与没有叶子节点的普通节点非常相似,尤其是在暗模式下,很难快速区分节点是否有子节点。 建议更新 UI 以提高差异化。 就个人而言,我建议删除叶节点框中的实心圆圈。

Add Image: image

For reference, here is the solution used by the tabs outliner. image

@GarinZ up for this, it's really difficult to differentiate if it has child or not. the referenced example used on tabs outliner are good, may put an indicator of n number of tabs, 1 tab means no indicator. i was hoping to see the latest update on this project, but it seems already dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

8 participants