Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save event start and end datetimes and timezone as meta #803

Closed
1 task done
mauteri opened this issue Aug 15, 2024 · 4 comments · Fixed by #820
Closed
1 task done

Save event start and end datetimes and timezone as meta #803

mauteri opened this issue Aug 15, 2024 · 4 comments · Fixed by #820
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mauteri
Copy link
Contributor

mauteri commented Aug 15, 2024

Is your enhancement related to a problem? Please describe.

Currently, GatherPress stores datetimes and timezone to a custom table which is used to query events in a scalable way. This change is to ALSO store this data as post meta so it is more easily accessible to developers and in the API. We can use the same approach of pseudo post meta illustrated in this ticket #560

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mauteri mauteri added the enhancement New feature or request label Aug 15, 2024
@mauteri mauteri added this to the 0.31.0 milestone Aug 15, 2024
@carstingaxion
Copy link
Collaborator

This sounds interesting, but I wonder if you really want to STORE the data in a second place or just make it available through the common APIs, post_meta for example?

@mauteri
Copy link
Contributor Author

mauteri commented Aug 15, 2024

@carstingaxion yeah, i was thinking that. the approach you illustrated in #560 for getting data from other places via post meta filter could suffice here.

@mauteri mauteri self-assigned this Aug 16, 2024
@carstingaxion
Copy link
Collaborator

I agree. One thing to keep in mind is, in opposite to #560, we need to make sure that meta revisions are disabled for that. Otherwise we could ran into out-of-sync issues with the custom db table.

https://make.wordpress.org/core/2023/10/24/framework-for-storing-revisions-of-post-meta-in-6-4/

@mauteri
Copy link
Contributor Author

mauteri commented Aug 22, 2024

I agree. One thing to keep in mind is, in opposite to #560, we need to make sure that meta revisions are disabled for that. Otherwise we could ran into out-of-sync issues with the custom db table.

https://make.wordpress.org/core/2023/10/24/framework-for-storing-revisions-of-post-meta-in-6-4/

Good call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants