Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase version to avoid confusion with easybook/geshi #79

Closed
splitbrain opened this issue Mar 16, 2017 · 10 comments
Closed

increase version to avoid confusion with easybook/geshi #79

splitbrain opened this issue Mar 16, 2017 · 10 comments

Comments

@splitbrain
Copy link
Contributor

easybook/geshi was the defacto standard for installing geshi via composer for quite a while (eg. it still has more downloads at packagist and is suggested first when searching for geshi). They applied some fixes in their fork and increased their version number. They are currently at 1.0.8.18

This repository has all the fixes they have (as far as I can see) and more. To avoid confusion about which is the more up-to-date release, the official version should be bumped. I would argue that dropping the PHP4 support warrants a 1.0.9 release, but everything higher than 1.0.8.18 should do.

@splitbrain
Copy link
Contributor Author

Turns out there are things in easybook that are missing here. See #80

@splitbrain splitbrain mentioned this issue Mar 16, 2017
12 tasks
@cweiske
Copy link
Member

cweiske commented Mar 17, 2017

We'll release a new version once the main issues are solved.

@splitbrain
Copy link
Contributor Author

what's the status here? can we get a new release?

@cweiske
Copy link
Member

cweiske commented Mar 28, 2017

I did not yet merge the doc changes.
New version will arrive within the next couple of weeks.

@cweiske
Copy link
Member

cweiske commented Mar 30, 2017

The git repo is prepared for 1.0.9.0. I've contacted @BenBE to get the release rolling (sourceforge, pear channel, git tag).

@BenBE
Copy link
Contributor

BenBE commented May 7, 2017

Currently coordinating things with @cweiske regarding the next release(s).

Regarding versioning in forks: If you ABSOLUTELY MUST make up your own version numbers please use Debian versioning format (1.0.8.12+forkname5), git describe style (1.0.8.12-23-g4711abc) or a combination thereof (1.0.8.12+forkname5-g00dc0de). Doing so helps with relating code bases for users.

On to the releases: Planned are two releases:

  • Version 1.0.8.13 to include almost all currentyl unreleased changes
  • Version 1.0.9.0 to include a compatibility bump to require PHP 7+

With the version 1.0.9.0 in the pipeline the confusion regarding the easybook versions of GeSHi.

Both releases should become available during the course of this week.

@splitbrain
Copy link
Contributor Author

1.0.8.13 will still be smaller than easycode's 1.0.8.18 which defeats the purpose of this ticket.

@splitbrain
Copy link
Contributor Author

BTW. there's a tag missing for 1.0.8.13 - packagist is still listing 1.0.8.12

@BenBE
Copy link
Contributor

BenBE commented May 14, 2017

Backlog of other projects/tasks on my list slowed things down somewhat. Should be resolved soon.

@cweiske
Copy link
Member

cweiske commented May 15, 2017

GeSHi 1.0.9.0 is on packagist now: https://packagist.org/packages/geshi/geshi#v1.0.9.0

@cweiske cweiske closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants