Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support MSVC #161

Closed
wants to merge 3 commits into from
Closed

WIP: Support MSVC #161

wants to merge 3 commits into from

Conversation

jaune
Copy link
Contributor

@jaune jaune commented Aug 21, 2023

Support MSVC, compile, and run.

Tested only with a console.log in _ready.

@jaune jaune changed the title fix: msvc Support msvc Aug 21, 2023
@jaune jaune changed the title Support msvc WIP: Support MSVC Aug 21, 2023
@fire
Copy link
Collaborator

fire commented Aug 24, 2023

There are some python whitespace changes:

diff --git a/config.py b/config.py
index b846f34..c2c7eae 100644
--- a/config.py
+++ b/config.py
@@ -1,5 +1,5 @@
 def can_build(env, platform):
-    return True #(platform == "windows" and env["use_mingw"]) or platform == "linux" or platform == "macos"
+    return True  # (platform == "windows" and env["use_mingw"]) or platform == "linux" or platform == "macos"
 
 
 def configure(env):

@jaune jaune closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants