-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate how built-in model validations works #33
Comments
Good news 🎉 The built-in validations seem to be flexible enough to allow adding custom validation sources that are combined with the default EMF diagnostics. How Sirius Web validations workValidation providers are registered by implementing the Lines 42 to 56 in 905d5ec
which sets up how this provider will return validations. In this particular case, diagnostic messages are gathered by calling the Lines 58 to 66 in 905d5ec
This method is not called when the diagram changes visually. It gets called only when the EMF side (the model itself) changes. How we can use the existing validations frameworkInstead of providing a custom way of emitting validations (#14), we can leverage the built-in validations framework by creating a new We do not need #15, and #19 is done automatically because the built-in validations are streamed to the UI using a GraphQL subscription. See #55 for a continuation of this work. |
Before implementing custom endpoints for model validations (#14), let's investigate how built-in model validation works.
https://github.com/Gelio/CAL-web/blob/main/backend/sirius-web-services/src/main/java/org/eclipse/sirius/web/services/validation/ValidationDescriptionProvider.java
Maybe we could leverage the built-in validation instead of building our own.
The text was updated successfully, but these errors were encountered: