Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scraper - Scraped Game Data Enhancement #85

Open
cdaters opened this issue Aug 30, 2024 · 1 comment
Open

Scraper - Scraped Game Data Enhancement #85

cdaters opened this issue Aug 30, 2024 · 1 comment

Comments

@cdaters
Copy link

cdaters commented Aug 30, 2024

At least for ScreenScraper (as I am not sure if the others include this or not), allow for the scraping of the ScreenScraper Staff Top Picks as a "Favorite" element/resource metadata into the resource db.xml cache to include in the gamelist.xml generation process so that EmulationStation can show that relative title as a favorite... For example:

...
<rating>x.x</rating
<favorite>true</favorite>
<desc>blah blah blah...</desc>
...

...is included for that title if it exists or no sub-child element for 'favorite' for that title is written to the gamelist if not:

...
<rating>x.x</rating
<desc>blah blah blah...</desc>
...
@github-staff github-staff deleted a comment from cdaters Sep 3, 2024
@Gemba
Copy link
Owner

Gemba commented Oct 20, 2024

I am not sold, if I should consider this for reasons:
a) a favorite I like to pick by myself and not by someone else, YMMV
b) for that reason a favorite setting is untouched between Skyscraper runs
c) what if the staff pick changes (ie. no longer staff pick on screenscraper site), but the user wants to keep the favorite (or vice versa: a user does not want it in the favorites, although it is a staff pick)?

There could be the option to the combination screenscraper and EmulationStation to create a custom collection for ES like "Screenscraper Top Picks". This collection could be rewritten every time Skyscraper runs and won't be convoluted with the regular favorites collection. But I don't like to have Skyscraper bloating into the specifics of ES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@Gemba @cdaters and others