-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better return values for grdinfo #593
Comments
This issue was mentioned in #1120, but it is not clear to me how this would be changed in a backwards compatible way. Does anyone have ideas for how to follow the deprecation policy here? Or should it be considered a bug where the deprecation policy may not apply? |
My guess for why this was brought up is that if the default option is return a dictionary, this will break functions that expect a string returned. Truth be told, I think the people most affected by this deprecation would be pygmt maintainers because of the number of tests that use My thought for the implementation of this is a parameter along the lines of |
Just wanted to surface a point I made in #1418 (comment). Please try and refrain from using pygmt/pygmt/tests/test_sphdistance.py Lines 43 to 46 in 2edaa63
Try to keep this in mind when reviewing PRs or wrapping new modules. We should also maybe start migrating tests using |
Thanks Meghan for making the list! I'm just wondering though, since the SRTM+v2.3 grids will be coming soon-ish (GenericMappingTools/gmtserver-admin#105), if we should refactor the grd* tests now, or wait until the new Oh, and by next release, do you mean PyGMT v0.5.0 or v0.6.0? |
I was (probably naively) hoping for v0.5.0. But since we have a bit of a backlog in PRs and not much time until the release, we could hold off until v0.6.0 and after the remaking of earth_relief grids. |
Description of the desired feature
Certain
pygmt.grdinfo
return values can be in an array form rather than a string. This would be a good first issue to take up, and would be similar to #575 but for grids instead of tables.Originally posted by @liamtoney in #147 (comment)
Are you willing to help implement and maintain this feature? Yes/No
The text was updated successfully, but these errors were encountered: