Change test_grdgradient.py to use static_earth_relief #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
added
maintenance
23 tasks
|
Just a quick note for while you're updating the open PRs that you could use an even smaller subregion from |
maxrjones
reviewed
Feb 9, 2022
pygmt/tests/test_grdgradient.py
Outdated
| npt.assert_allclose(temp_grid.max(), 0.0575332976) | ||
| npt.assert_allclose(temp_grid.median(), 0.0004889865522272885) | ||
| npt.assert_allclose(temp_grid.mean(), 0.0028633063193410635) | ||
| result = grdgradient(grid=grid, azimuth=10, direction="c") |
There was a problem hiding this comment.
In future GMT releases, azimuth and direction will not be allowed together because the two options are contradictory (see discussion in GenericMappingTools/gmt#6327). Sorry for the extra work, but I recommend updating this test to use only one of these two parameters.
Good idea! |
maxrjones
approved these changes
Feb 14, 2022
maxrjones
added
the
final review call
seisman
approved these changes
Feb 15, 2022
seisman
changed the title
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR refactors the pygmt.grdgradient tests to use xarray.testing.assert_allclose() rather than pygmt.grdinfo() in preparation for the deprecation associated with better return values for grdinfo (#593).
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version