Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xarray.testing rather than pygmt.grdinfo in xyz2grd tests #1682

Merged
merged 10 commits into from
Feb 18, 2022

Conversation

willschlitzer
Copy link
Contributor

Description of proposed changes

This PR refactors the pygmt.xyz2grd tests to use xarray.testing.assert_allclose() rather than pygmt.grdinfo() in preparation for the deprecation associated with better return values for grdinfo (#593).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 21, 2021
@willschlitzer willschlitzer added this to the 0.6.0 milestone Dec 21, 2021
@willschlitzer willschlitzer self-assigned this Dec 21, 2021
pygmt/tests/test_xyz2grd.py Show resolved Hide resolved
pygmt/tests/test_xyz2grd.py Outdated Show resolved Hide resolved
@willschlitzer
Copy link
Contributor Author

@meghanrjones This is listed at #1684 as a test to use static_earth_relief. Would it be better to use load_sample_bathymetry that already has xyz-data?

@maxrjones
Copy link
Member

@meghanrjones This is listed at #1684 as a test to use static_earth_relief. Would it be better to use load_sample_bathymetry that already has xyz-data?

Yes, that was an oversight. It would be better to use xyz-data.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 17, 2022
@maxrjones maxrjones merged commit 3b65997 into main Feb 18, 2022
@maxrjones maxrjones deleted the remove-grdinfo/xyz2grd branch February 18, 2022 19:37
@maxrjones maxrjones removed the final review call This PR requires final review and approval from a second reviewer label Feb 18, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…cMappingTools#1682)

Update xyz2grd tests to use xarray.testing and new syntax for loading data

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants