-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use xarray.testing rather than pygmt.grdinfo in xyz2grd tests #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
added
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
labels
Dec 21, 2021
seisman
reviewed
Dec 22, 2021
23 tasks
@meghanrjones This is listed at #1684 as a test to use |
Yes, that was an oversight. It would be better to use xyz-data. |
maxrjones
reviewed
Feb 11, 2022
seisman
reviewed
Feb 15, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Feb 17, 2022
seisman
added
the
final review call
This PR requires final review and approval from a second reviewer
label
Feb 17, 2022
maxrjones
approved these changes
Feb 18, 2022
maxrjones
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Feb 18, 2022
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…cMappingTools#1682) Update xyz2grd tests to use xarray.testing and new syntax for loading data Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR refactors the pygmt.xyz2grd tests to use xarray.testing.assert_allclose() rather than pygmt.grdinfo() in preparation for the deprecation associated with better return values for grdinfo (#593).
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version