Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for UTF with JSON3 #91

Closed
essenciary opened this issue Jan 21, 2022 · 5 comments
Closed

Support for UTF with JSON3 #91

essenciary opened this issue Jan 21, 2022 · 5 comments
Assignees
@essenciary
Labels
bug Something isn't working

Comments

@essenciary
Copy link
Member

zy_os — Yesterday at 5:39 PM
@essenciary to resolve this bug, I fould that it need to change Stipple.jl :39 @inline JSON3.rawbytes(x::JSONText) = x.s -> @inline JSON3.rawbytes(x::JSONText) = codeunits(x.s)
@essenciary essenciary self-assigned this Jan 21, 2022
@essenciary essenciary added the bug Something isn't working label Jan 21, 2022
@hhaensel
Copy link
Member

Very true!

@hhaensel
Copy link
Member

@essenciary
Are you doing it?

@essenciary
Copy link
Member Author

Yes! Just want to test it before tagging a new release, to make sure it doesn't break anything.

@hhaensel
Copy link
Member

Sounds good. Your fix looks should be ok. It's the same way how we fixed JSON3 for PlotlyBase ...

@essenciary
Copy link
Member Author

This has been released yesterday in v0.20.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@essenciary essenciary

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@essenciary @hhaensel