Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrcpy ends the session if not started from terminal #182

Closed
ghost opened this issue Jun 22, 2018 · 3 comments

Comments

@ghost
Copy link

commented Jun 22, 2018

I tried to make a desktop entry to start the program from the toolbar, but when I close it or unplug the USB cable it simply ends the session I am currently in (Ubuntu 17.10).

@ghost ghost changed the title Scrcpy ends the session if not started from a terminal Scrcpy ends the session if not started from terminal Jun 22, 2018

@rom1v

This comment has been minimized.

Copy link
Collaborator

commented Jun 22, 2018

Possibly related: #52

@rom1v

This comment has been minimized.

Copy link
Collaborator

commented Jun 22, 2018

Could you try with current master, I just fixed a bug that might explain the issue: 1a01393

@rom1v rom1v added the bug label Jun 22, 2018

rom1v added a commit that referenced this issue Jun 22, 2018
Prevent killing unexpected process
A missing initialization (fixed by the previous commit) leaded to kill
unexpected process.

In order to prevent consequences of similar errors in the future, never
call kill() with a non-positive PID.

See <#182>.
@ghost

This comment has been minimized.

Copy link
Author

commented Jun 26, 2018

Sorry to answer a bit later. I tested it and the bug seems to be fixed. Thanks!

@rom1v rom1v closed this Jun 26, 2018

LeonardoManzella added a commit to LeonardoManzella/scrcpy that referenced this issue Aug 15, 2018
Rebase and Merge with Master - From v1.2 to v1.3
- Fix missing initialization that leaded to kill the whole process
- group on quit (Genymobile#182, Genymobile#183)
- Support holding Ctrl+Key shortcuts (Genymobile#166)
- Forward repeated volume events
- Increase "adb forward" connections attempts to 10 seconds (Genymobile#213)
- Add crop feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.