Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--show-touches does not turn off automatically #183

Closed
vshymanskyy opened this issue Jun 22, 2018 · 6 comments
Closed

--show-touches does not turn off automatically #183

vshymanskyy opened this issue Jun 22, 2018 · 6 comments
Assignees
@rom1v
Labels
bug

Comments

@vshymanskyy
Copy link

After scrcpy is closed, the option remains enabled on the smartphone.
Ubuntu Linux, Xiomi Redmi 4 Pro (Android 6)
@rom1v
Copy link
Collaborator

rom1v commented Jun 22, 2018

It should be turned off automatically if scrcpy is properly closed while the device is still connected.

Otherwise, it can't. 😞

@rom1v
Copy link
Collaborator

rom1v commented Jun 22, 2018

Oh, you're right, there is a problem.

@rom1v rom1v added the bug label Jun 22, 2018
@rom1v rom1v self-assigned this Jun 22, 2018
rom1v added a commit that referenced this issue Jun 22, 2018
@rom1v
Fix missing installer initialization
1a01393 
The current_process field of struct installer was not initialized.
Since the installer instance is static, its default value was 0.

The call to installer_stop() then called kill(0, SIGTERM) (on Linux),
which sent SIGTERM to every process in the process group. In particular,
the scrcpy process was killed.

As a consequence, the last cleanup steps, like disabling "show touches",
were not executed.

Fixes <#183>.
@rom1v
Copy link
Collaborator

rom1v commented Jun 22, 2018

Fixed on master.

Thank you for the report 👍

@rom1v rom1v closed this as completed Jun 22, 2018
LeonardoManzella added a commit to LeonardoManzella/scrcpy that referenced this issue Aug 15, 2018
@LeonardoManzella
Rebase and Merge with Master - From v1.2 to v1.3
84f9467 
- Fix missing initialization that leaded to kill the whole process
- group on quit (Genymobile#182, Genymobile#183)
- Support holding Ctrl+Key shortcuts (Genymobile#166)
- Forward repeated volume events
- Increase "adb forward" connections attempts to 10 seconds (Genymobile#213)
- Add crop feature
@madduck
Copy link
Contributor

madduck commented Jan 7, 2020

It should be turned off automatically if scrcpy is properly closed while the device is still connected.

Otherwise, it can't. disappointed

Why not? Doesn't the device run the server?

Also, what is "properly closed"? There is no quit command…

@rom1v
Copy link
Collaborator

rom1v commented Jan 9, 2020

Why not? Doesn't the device run the server?

It closes as soon as adb shell terminates (e.g. on unplug).

We could keep it alive (see #679), but not done yet.

Also, what is "properly closed"?

Close the window.

@madduck
Copy link
Contributor

madduck commented Jan 9, 2020

Thanks for your response, @rom1v!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rom1v rom1v

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madduck @rom1v @vshymanskyy