Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: adb.exe process continues to run after scrcpy is closed #205

Closed
HatTrkPatrk opened this issue Jul 21, 2018 · 3 comments
Closed

Minor: adb.exe process continues to run after scrcpy is closed #205

HatTrkPatrk opened this issue Jul 21, 2018 · 3 comments
Labels
adb notabug

Comments

@HatTrkPatrk
Copy link

HatTrkPatrk commented Jul 21, 2018 •
edited
Loading

Very minor issue on Win10 (other Windows OSes unconfirmed as I don't have access to them to test) in the grand scheme of things but felt it should be logged anyway.

After closing scrcpy, the adb.exe process it launches continues to run in the background, requiring termination via the Task Manager.

I'm unsure what (if any) information would be helpful in diagnosing this, or even if anything can be done about it (seeing as the exe is an Android one not technically scrcpy) but I can provide any needed details.
@rom1v
Copy link
Collaborator

rom1v commented Jul 21, 2018 •
edited
Loading

This is expected. adb starts a daemon as soon as you use it, which is used for every adb command.

Even without scrcpy, just type adb devices for example, the daemon will stay started.

Killing it would be wrong, since it would break any other parallel usage of adb when you close scrcpy.

You can stop it manually with adb kill-server.

@rom1v rom1v closed this as completed Aug 19, 2018
@rom1v rom1v mentioned this issue May 29, 2019
Open
@rom1v rom1v mentioned this issue Oct 1, 2020
Closed
@rom1v rom1v mentioned this issue Feb 7, 2021
Open
@mruac
Copy link

mruac commented Feb 8, 2021

If you had to reference this issue many times @rom1v , why not add the command to the main main release so that this is done automatically?

@rom1v rom1v mentioned this issue Aug 9, 2022
Closed
2 tasks
@rom1v rom1v mentioned this issue Feb 28, 2023
Open
rom1v added a commit that referenced this issue Jun 5, 2023
@rom1v
Add option to kill adb on close
05471af 
Killing adb on close by default would be incorrect, since it would break
any other usage of adb in parallel.

It could be easily done manually by calling "adb kill-server" once
scrcpy terminates, but add an option --kill-adb-on-close for
convenience.

Fixes #205 <#205>
Fixes #2580 <#2580>
Fixes #4049 <#4049>
rom1v added a commit that referenced this issue Jun 5, 2023
@rom1v
Add option to kill adb on close
a3cdf1a 
Killing adb on close by default would be incorrect, since it would break
any other usage of adb in parallel.

It could be easily done manually by calling "adb kill-server" once
scrcpy terminates, but add an option --kill-adb-on-close for
convenience.

Fixes #205 <#205>
Fixes #2580 <#2580>
Fixes #4049 <#4049>
@rom1v
Copy link
Collaborator

rom1v commented Jun 5, 2023

Implemented option --kill-adb-on-close: a3cdf1a

@rom1v rom1v mentioned this issue Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adb notabug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rom1v @HatTrkPatrk @mruac