Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill adb.exe on exit #2580

Closed
FatheredPuma81 opened this issue Aug 22, 2021 · 4 comments
Closed

Kill adb.exe on exit #2580

FatheredPuma81 opened this issue Aug 22, 2021 · 4 comments

Comments

@FatheredPuma81
Copy link

Really hard to search for this so sorry if it's a duplicate.

Issue: adb.exe is still in task manager after program exits/closes.
Solution: Kill adb.exe on program exit.

Not a big deal but it would be nice.
@npes87184
Copy link
Contributor

There is a possible that other processes are using adb. If scrcpy kill adb when it exists, it will cause some problem in other processes.

@FatheredPuma81
Copy link
Author

How about the option to automatically kill it then?

@gaussandhisgun
Copy link

why not just run it like scrcpy && adb kill-server, so adb will be killed the moment scrcpy successfully finishes its work?

rom1v added a commit that referenced this issue Jun 5, 2023
@rom1v
Add option to kill adb on close
05471af 
Killing adb on close by default would be incorrect, since it would break
any other usage of adb in parallel.

It could be easily done manually by calling "adb kill-server" once
scrcpy terminates, but add an option --kill-adb-on-close for
convenience.

Fixes #205 <#205>
Fixes #2580 <#2580>
Fixes #4049 <#4049>
@rom1v
Copy link
Collaborator

rom1v commented Jun 5, 2023

Implemented option --kill-adb-on-close: a3cdf1a

@rom1v rom1v closed this as completed in a3cdf1a Jun 21, 2023
@rom1v rom1v mentioned this issue Jun 25, 2024
Open
@rom1v rom1v mentioned this issue Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rom1v @npes87184 @FatheredPuma81 @gaussandhisgun