Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback, V2.2: Just a video feedback of your tool working on Lynx R1. (Maybe it can help the team) #4403

Open
EloiStree opened this issue Nov 5, 2023 · 6 comments

Comments

@EloiStree
Copy link

EloiStree commented Nov 5, 2023

Hello the team.
Just wanted to say: THANK YOU :) !!!

Just fall on the V2.2 and try it on the Lynx R1 and phone:
https://youtu.be/5PAxE4_s80E

image
That the face of someone that love what you did there :)

🍀 And it is amazing. 🦄

( on the side note, I suppose there is not option I am missing to have two cameras at the same time ? )

@rom1v
Copy link
Collaborator

rom1v commented Nov 5, 2023

Thank you for the feedback, it's nice 😍

At 3:25, --camera-face → it's not working because it's --camera-facing.

At 4:25, your encoder probably does not support this resolution, try with a lower resolution (for example, pass -m1920).

At 5:24, the error is very weird (lower must be less than or equal to upper), it looks like a bug in the ROM when they retrieve the fps ranges.

Please retry with this server instead (replace the file in your v2.2 release) and post the result of --list-cameras:

  • scrcpy-server SHA-256: 22b93af6d1cd122652b3cc2b90fe15eff905647ddbae3d9f723d6174e27366e8

(built from branch camerafpsranges

At 7:30, to turn audio off, it's --no-audio.

I suppose there is not option I am missing to have two cameras at the same time ?

I would suggest to run 2 scrcpy instances at the same time with different camera, but I just tested, running the second closes the first one.

rom1v added a commit that referenced this issue Nov 5, 2023
Some devices may provide invalid ranges, causing an
IllegalArgumentException "lower must be less than or equal to upper".

Catch the exception to list the cameras anyway.

Refs #4403 <#4403>
@yume-chan
Copy link
Contributor

Just a guess, the broken front camera on your Samsung phone might be the optical fingerprint sensor. I had seen news about other device also had fingerprint sensors exposed as cameras.

@rom1v
Copy link
Collaborator

rom1v commented Nov 8, 2023

At 5:24, the error is very weird (lower must be less than or equal to upper), it looks like a bug in the ROM when they retrieve the fps ranges.

Please retry with this server instead (replace the file in your v2.2 release) and post the result of --list-cameras:

  • scrcpy-server SHA-256: 22b93af6d1cd122652b3cc2b90fe15eff905647ddbae3d9f723d6174e27366e8

(built from branch camerafpsranges

Could you please test and confirm (or not) that it solves this specific issue?

rom1v added a commit that referenced this issue Nov 11, 2023
Some devices may provide invalid ranges, causing an
IllegalArgumentException "lower must be less than or equal to upper".

Catch the exception to list the cameras anyway.

Refs #4403 <#4403>
@groegerjo
Copy link

At 5:24, the error is very weird (lower must be less than or equal to upper), it looks like a bug in the ROM when they retrieve the fps ranges.
Please retry with this server instead (replace the file in your v2.2 release) and post the result of --list-cameras:

  • scrcpy-server SHA-256: 22b93af6d1cd122652b3cc2b90fe15eff905647ddbae3d9f723d6174e27366e8

(built from branch camerafpsranges

Could you please test and confirm (or not) that it solves this specific issue?

Had much trouble with my phones (OnePlus 8T; LOS 20/Android 13 and Redmi Note 8T; EvolutionROM/Android 14)
After implementing the scrcpy-server mentioned above everything is working fine.
Thank you for the workaround.

@EloiStree
Copy link
Author

EloiStree commented Nov 13, 2023

At 5:24, the error is very weird (lower must be less than or equal to upper), it looks like a bug in the ROM when they retrieve the fps ranges.
Please retry with this server instead (replace the file in your v2.2 release) and post the result of --list-cameras:

  • scrcpy-server SHA-256: 22b93af6d1cd122652b3cc2b90fe15eff905647ddbae3d9f723d6174e27366e8

(built from branch camerafpsranges

Could you please test and confirm (or not) that it solves this specific issue?

Sorry I transmitted the link to the Lynx team the other day.
(Just wanted to say thank ^^ with this issue was not expecting a full reply ;) )

I will try to understand what I need to do tomorrow with your request.
I suppose that you ask to download the tool from the given branch with git.

Can't do that now, will try to find the time.

@Utopiah
Copy link

Utopiah commented Nov 17, 2023

same problem, lower must be less than or equal to upper including with the camerafpsranges built (I believe but unsure as I don't see the SHA from the client) :

fabien@fabien-CORSAIR-ONE-i160:~/Prototypes/scrcpy$ scrcpy --list-cameras
scrcpy v2.2 <https://github.com/Genymobile/scrcpy>
INFO: ADB device found:
INFO:     -->   (usb)  c12becc8                        device  Lynx_R1
/usr/local/share/scrcpy/scrcpy-server: 1 file pushed, 0 skipped. 6.7 MB/s (154545 bytes in 0.022s)
[server] INFO: Device: [Lynx Mixed Reality] Lynx-R Lynx-R1 (Android 12)
[server] ERROR: java.lang.reflect.InvocationTargetException
java.lang.AssertionError: java.lang.reflect.InvocationTargetException
        at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal(MarshalQueryableRange.java:95)
        at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal(MarshalQueryableRange.java:37)
        at android.hardware.camera2.marshal.impl.MarshalQueryableArray$MarshalerArray.unmarshal(MarshalQueryableArray.java:157)
        at android.hardware.camera2.impl.CameraMetadataNative.getBase(CameraMetadataNative.java:611)
        at android.hardware.camera2.impl.CameraMetadataNative.get(CameraMetadataNative.java:471)
        at android.hardware.camera2.impl.CameraMetadataNative.get(CameraMetadataNative.java:440)
        at android.hardware.camera2.CameraCharacteristics.get(CameraCharacteristics.java:295)
        at com.genymobile.scrcpy.LogUtils.buildCameraListMessage(LogUtils.java:111)
        at com.genymobile.scrcpy.Server.internalMain(Server.java:228)
        at com.genymobile.scrcpy.Server.main(Server.java:190)
        at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
        at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:355)
Caused by: java.lang.reflect.InvocationTargetException
        at java.lang.reflect.Constructor.newInstance0(Native Method)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:343)
        at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal(MarshalQueryableRange.java:87)
        ... 11 more
Caused by: java.lang.IllegalArgumentException: lower must be less than or equal to upper
        at android.util.Range.<init>(Range.java:60)
        ... 14 more

while running scrcpy without any parameters works well (but shows no camera).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants