[Request for tests] Refactor rendering and events position/scaling #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the screen knows what to do when the window is resized. This paves the way to do other actions on window resizing.
Position and scale the content "manually" instead of relying on the renderer "logical size". This avoids possible rounding differences between the computed window size and the content size, causing one row or column of black pixels on the bottom or on the right. This will also enable to draw items at their expected size on the screen (unscaled).
The window dimensions are integers, so resizing to fit the content may not be exact. When computing the optimal size, it could cause to reduce the width and height alternatively by few pixels, making the "optimal size" unstable. For the same reason, during rendering, the content size could be different from the optimal window size, leading to black borders (supposed to be removed in optimal size). To avoid this problem, always choose the same dimension if the choice to resize the width or the height is in the error range.
|
With a setup similar to my initial post in #15 Launching scrcpy on the macOS (retina, hidpi) side, everything works well:
However, the transition between screens breaks the display of scrcpy. Moving from the retina screen to the normal screen results in a zoomed out UI In that state, the touch input are actually correct based on the window size. Moving back the "fixed" window from the normal screen to the retina screen results in a zoomed in UI Once again, rotating/resizing the window fixes the display. Using Cmd + Left / Cmd + Right to rotate the window works well on both screens! 👍 |
2 tasks
|
There are still issues, and it's too risky for a release… I didn't merge it for now. Thank you for your feedbacks :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset removes calls to
SDL_RenderSetLogicalSize()and position and scale the content (and the events) manually.This has several benefits:
It's been a long time since I want to do this change, but it is quite "dangerous" as it impacts heavily the rendering and the event forwarding.
Therefore, I'm very interested in testing from users. Especially on macOS (but not only) (because I don't have any macOS to test), especially with HiDPI (but not only), especially with a secondary monitor (#15) (but not only).
Please also test clicks after window rotation (Ctrl+Left and Ctrl+Right, a new feature in the next release).
In theory, this is the last remaining change I would like to merge before a new release.
Thank you for your feedbacks.
EDIT: please test
logical_size.8instead