Rendering rework #1408
Rendering rework #1408
Conversation
When the content size changes, either on frame size or client rotation changes, the window must be resized. Factorize for both cases.
If the content size changes (due to rotation for example) while the window is maximized or fullscreen, the resize must be applied once fullscreen and maximized are disabled. The previous strategy consisted in storing the windowed size, computing the target size on rotation, and applying it on window restoration. But tracking the windowed size (while ignoring the non-windowed size) was tricky, due to unspecified order of SDL events (e.g. size changes can be notified before "maximized" events), race conditions when reading window flags, different behaviors on different platforms... To simplify the whole resize management, store the old content size (the frame size, possibly rotated) when it changes while the window is maximized or fullscreen, so that the new optimal size can be computed on window restoration.
On Windows, in maximized+fullscreen state, disabling fullscreen mode unexpectedly triggers the "restored" then "maximized" events, leaving the window in a weird state (maximized according to the events, but not maximized visually). Moreover, apply_pending_resize() asserts that fullscreen is disabled. To avoid the issue, if fullscreen is set, just ignore the "restored" event.
In maximized state (but not fullscreen), it was possible to resize to fit the device screen (with Ctrl+x or double-clicking on black borders). This caused problems on macOS with the "expand to fullscreen" feature, which behaves like a fullscreen mode but is seen as maximized by SDL. In that state, resizing to fit causes unexpected results. To keep the behavior consistent on all platforms, just disable "resize to fit" when the window is maximized.
Extract the computation to detect whether the current size of the window is already optimal. This will allow to reuse it for rendering.
Position and scale the content "manually" instead of relying on the renderer "logical size". This avoids possible rounding differences between the computed window size and the content size, causing one row or column of black pixels on the bottom or on the right. This also avoids HiDPI scale issues, by computing the scaling manually. This will also enable to draw items at their expected size on the screen (unscaled). Fixes #15 <#15>
|
Tried out all cases which you described. Seems like the issue is fixed on all of them!
What did you mean with "expand to fullscreen"? I tried starting it with Edit: Green button, not yellow |
🎉
https://support.apple.com/fr-fr/guide/mac-help/mchl9c21d2be/mac |
|
Yeah I did that, haha. All fine |
|
It seems to work as expected (I also did more tests and received private feedbacks). So I just merged it into |
I reworked many things related to the window/rendering.
Firstly, I improved the maximized/fullscreen handling to avoid weird behaviors on some platforms (see commit messages 6dc113e and eb189ce).
Then, (as a followup of #1307 that I closed because it was not ready) I reworked the rendering to position and scale the content (and the events) manually (i.e. without using the SDL "logical size" feature). (commit a6dcbf3)
It has several benefits:
I am now quite confident that it works correctly.
But since it impacts heavily the rendering and the event forwarding (which must NOT be broken at all), more tests from users are welcome:
Ctrl+←/Ctrl+→)Ctrl+fand "expand to fullscreen", which behaves differently), rotate device, then unfullscreen (check that the window is correctly restored in maximized state), then unmaximize (check that the window is correctly restored at the correct size).Binaries
To simplify testing, here are binaries.
For windows users, take both
scrcpy.exeandscrcpy-server, and replace them in your scrcpy v1.13 release.For other platforms, take
scrcpy-serverand build only the client.scrcpy.exeSHA256: 7d61f31c8e33aa1b70a43b38b7c40c7e5289683a959e8426b34c3a488a385186
scrcpy-serverSHA256: 6d124307e081b8bbccc478dcf82731aad3cc994e7502197c9bae3847d3169dc7
Thank you for your feedbacks 😉