Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simplified Chinese translation for README.md. #1723

Closed
wants to merge 35 commits into from

Conversation

Win7GM
Copy link
Contributor

@Win7GM Win7GM commented Aug 30, 2020

No description provided.

@rom1v
Copy link
Collaborator

rom1v commented Sep 4, 2020

Thank you for the translation 👍

Could someone understanding the language review, please? (cc @npes87184 maybe?)

@npes87184
Copy link
Contributor

Oh yes, I can review this patch.
I will find time to do it.

@rom1v
Copy link
Collaborator

rom1v commented Sep 5, 2020

Thank you very much 😉

Copy link
Contributor

@shawyunz shawyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guy, I tended to translate recently and found this one, so did some review here.
Please check the comments below, normally I just put my personal updated translation there.
And feel free to tell me anything wrong I did.

One word I didn't change throughout the file is "mirror/mirroring", which was translated as "共享", but I assumed that "镜像" could be a better choice.

Cheers.

README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
README_zh.md Outdated Show resolved Hide resolved
@shawyunz
Copy link
Contributor

And as there is already a file named "README.zh-Hant.md", this one could named as "README.zh-Hans.md" to be consistent.

Win7GM and others added 15 commits September 10, 2020 12:18
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Copy link
Contributor

@shawyunz shawyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "共享" and "输出" with "镜像".

README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
README_zh-Hans.md Outdated Show resolved Hide resolved
@npes87184
Copy link
Contributor

How about replace "本应用程式", "该应用程式", "应用程式" with scrcpy?

Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Win7GM and others added 9 commits September 10, 2020 17:18
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
@Win7GM
Copy link
Contributor Author

Win7GM commented Sep 10, 2020

How about replace "本应用程式", "该应用程式", "应用程式" with scrcpy?

It is a good idea. Would you please propose a suggestion?

@shawyunz
Copy link
Contributor

How about replace "本应用程式", "该应用程式", "应用程式" with scrcpy?

Theoretically, that depends on original words, but it's always good to have a consistent naming convention.

@Win7GM
Copy link
Contributor Author

Win7GM commented Sep 10, 2020

How about replace "本应用程式", "该应用程式", "应用程式" with scrcpy?

Theoretically, that depends on original words, but it's always good to have a consistent naming convention.

Yes indeed. I will find time to do the replacing myself if you want.

Changed most "应用程序" into "scrcpy".
@Win7GM
Copy link
Contributor Author

Win7GM commented Sep 11, 2020

How about replace "本应用程式", "该应用程式", "应用程式" with scrcpy?

Theoretically, that depends on original words, but it's always good to have a consistent naming convention.

I updated the file. Plz check if anything else needs to be changed. Thx.

Win7GM and others added 2 commits September 15, 2020 20:10
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
rom1v pushed a commit that referenced this pull request Sep 17, 2020
PR #1723 <#1723>

Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Sep 17, 2020

Thank you for the translation 👍

I squashed all the commits, and renamed README.zh-Hans.md (. instead of _ for consistency): zh-hans

Could you verify that everything is ok (name, co-author, content), please?

Could you also add a reference to this translation here (I could not do it because it requires some chinese text): https://github.com/Genymobile/scrcpy#translations (I'll squash it with the commit)

Thank you.

@shawyunz
Copy link
Contributor

Thank you for the translation 👍

Or take this one, @rom1v :

- [简体中文 (Simplified Chinese, `zh_Hans`) - v1.16](README.zh-Hans.md)

@Win7GM
Copy link
Contributor Author

Win7GM commented Sep 17, 2020

Thank you for the translation 👍

I squashed all the commits, and renamed README.zh-Hans.md (. instead of _ for consistency): zh-hans

Could you verify that everything is ok (name, co-author, content), please?

Could you also add a reference to this translation here (I could not do it because it requires some chinese text): https://github.com/Genymobile/scrcpy#translations (I'll squash it with the commit)

Thank you.

I've added the reference to README.md ( #1768 ) and the file in zh-hans looks good to me.

rom1v pushed a commit that referenced this pull request Sep 17, 2020
PR #1723 <#1723>

Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Sep 17, 2020
PR #1723 <#1723>

Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Sep 17, 2020
PR #1723 <#1723>

Co-authored-by: Shaw Yu <shawyu.nz@gmail.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Sep 17, 2020

Thank you 👍

Merged into master. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants