Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new option --encoder-name #1827

Closed
wants to merge 1 commit into from

Conversation

tzah4748
Copy link

Relates to issue #1810

It seems that some devices have more than one encoder, some encoders may cause issues or crash.
With this option we can specify which encoder we want the device to use.

Proved useful for the device in the issue.

@tzah4748
Copy link
Author

@rom1v did you get a chance to take a look?

@rom1v
Copy link
Collaborator

rom1v commented Oct 25, 2020

Sorry, not yet in details. Currently, I have no time to work on scrcpy (I just answer to issues if I can give a quick answer).

But I have it in mind (and in my todo list), and this option will be merged before a new release. 👍

One additional thing I would like to add is listing the available encoder names on error (like the --display option).

@rom1v rom1v closed this Oct 25, 2020
@rom1v rom1v reopened this Oct 25, 2020
rom1v pushed a commit that referenced this pull request Nov 8, 2020
Some devices have more than one encoder, some encoders may cause issues
or crash. With this option we can specify which encoder we want the
device to use.

PR #1827 <#1827>
Fixes #1810 <#1810>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Nov 8, 2020

I rebased on current dev, I changed the option --encoder-name to --encoder (for simplicity and consistency with --display to select the display id) and some minor other changed on your commit.
Then I added another commit to list the available encoders if an invalid name is passed.

Please review and test: encoder_name

If it's ok, I'll merge into dev :)

@tzah4748
Copy link
Author

tzah4748 commented Nov 8, 2020

Looks good to me!
Feel free to merge it.

rom1v pushed a commit that referenced this pull request Nov 8, 2020
Some devices have more than one encoder, and some encoders may cause
issues or crash. With this option we can specify which encoder we want
the device to use.

PR #1827 <#1827>
Fixes #1810 <#1810>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Nov 8, 2020

Merged into dev, thanks 👍

@rom1v
Copy link
Collaborator

rom1v commented Nov 12, 2020

Here are binaries for the current dev branch including this feature (it will be helpful to debug other issues).

For windows users, take both scrcpy.exe and scrcpy-server, and replace them in your scrcpy v1.16 release.

For other platforms, take scrcpy-server and build only the client.

  • scrcpy.exe
    SHA256: f0079664dc8954f62a486346d2267c6159d7cd47d0527d117f3c73350d2bb053
  • scrcpy-server
    SHA256: 1230ccd507e20a0ed0a307cd760968240b451de47a19cb2daaa3a5450893b7f9

(to replace in v1.16 release)

scrcpy --encoder _  # will list the available encoders in the error message
scrcpy --encoder SOME_ENCODER

jellopuddingstick added a commit to jellopuddingstick/scrcpy that referenced this pull request Jan 23, 2021
scrcpy v1.17

Changes since v1.16:
 - Fix errors on Android 11 (Genymobile#1468)
 - Add --encoder option (Genymobile#1810, Genymobile#1827)
 - Add --forward-all-clicks option (Genymobile#1302, Genymobile#1613)
 - Add --legacy-paste option (Genymobile#1750, Genymobile#1771)
 - Workaround screen off/on issue on exit (Genymobile#1670)
 - Rework console/noconsole versions on Windows (Genymobile#1875, Genymobile#1988)
 - Terminate server properly without killing it on close (Genymobile#1992)
 - List available shortcut keys on error (Genymobile#1681)
 - Upgrade platform-tools to 30.0.5 (adb) in Windows releases
 - Upgrade SDL to 2.0.14 in Windows releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants