Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Don't scale up images smaller than the media viewer window. #378

Closed
1 of 4 tasks
LukaszH77 opened this issue Jul 14, 2023 · 4 comments · Fixed by #380
Closed
1 of 4 tasks

[Request]: Don't scale up images smaller than the media viewer window. #378

LukaszH77 opened this issue Jul 14, 2023 · 4 comments · Fixed by #380
Labels
enhancement New feature or request

Comments

@LukaszH77
Copy link
Contributor

Describe the request

Small images in Lupe (and Fractal) open without zooming, but Tuba scales them to fill the media browser window. In most cases, this makes them look not great. Especially text in screenshots suffers from this.

Tuba and Loupe comparison
Zrzut ekranu z 2023-07-14 06-22-57
Zrzut ekranu z 2023-07-14 06-46-58

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@LukaszH77 LukaszH77 added the enhancement New feature or request label Jul 14, 2023
@GeopJr
Copy link
Owner

GeopJr commented Jul 15, 2023

Some of my thoughts on #148 (comment) apply here too:

There's also the question of sizing. Currently the images expand, taking as much space as possible while keeping aspect ratio. That makes zooming a bit more complex but it results in 99% of users not having to use zoom at all to view images. Having the images be a static size or having enough padding around them as "blank space for dismissing" would require all users to use the zoom functions which is not ideal (and disabled on videos/gifs/audio).

Note that Tuba's media viewer is not meant to replace your host's. It's meant to view/play multiple formats without opening them externally (images, videos, audio).

Personally I find Tuba's view more appropriate for the use case (especially in the bottom image of the two you sent) and would rather users not even need to zoom at all for 99% of the time, but I'll reconsider it if it interferes with the image readability

@LukaszH77
Copy link
Contributor Author

Maybe an option to turn off scaling up?

@GeopJr
Copy link
Owner

GeopJr commented Jul 16, 2023

Gave it a try on #380 (in settings)

@LukaszH77
Copy link
Contributor Author

It's great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants