Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FeatureTable and BatchTable #13

Open
elfprince13 opened this issue Jun 1, 2020 · 0 comments
Open

Refactor FeatureTable and BatchTable #13

elfprince13 opened this issue Jun 1, 2020 · 0 comments
Assignees

Comments

@elfprince13
Copy link
Contributor

a) FeatureTable should not inherit from BatchTable, but both should probably share a base-class.
b) Terminology that is specific to client formats (e.g. "global" vs "instance-wise" vs "point-wise") should not be part of the generic class interface; however, we need to make sure it supports the sub-tables for extensions and extras.
c) There is no need for any mutation. Each *Table instance should be constructed from a single collection that represents the entire table, and handle encoding that collection into the separate JSON and binary buffer portions. The result should be treated as effectively immutable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants