Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlaps #2466

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Fix overlaps #2466

merged 3 commits into from
Jan 8, 2021

Conversation

LePetitTim
Copy link
Contributor

@LePetitTim LePetitTim commented Jan 6, 2021

Fix #2465

Copy link
Contributor

@gutard gutard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a un cas qui n'est pas pris en compte (rien à voir avec cette PR, c'était déjà bugué avant), c'est quand l'intersection mélange point et linestring, par ex. GEOMETRYCOLLECTION(POINT(1 1),LINESTRING(1 2,1 1.5))

Je pense qu'il faut plutôt faire NOT ST_IsEmpty(ST_CollectionExtract(ST_intersection(geom, line), 2))

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2466 (6864067) into master (e8389dc) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2466   +/-   ##
=======================================
  Coverage   97.09%   97.10%           
=======================================
  Files         262      262           
  Lines       17019    17019           
=======================================
+ Hits        16525    16526    +1     
+ Misses        494      493    -1     
Impacted Files Coverage Δ
geotrek/core/forms.py 94.80% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8389dc...6864067. Read the comment docs.

@gutard gutard self-requested a review January 8, 2021 08:11
@gutard gutard merged commit f860e00 into master Jan 8, 2021
@gutard gutard deleted the fix_overlaps branch January 8, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"La géométrie en superpose une autre"
2 participants