Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structures to Aggregator (refs #3569) #4077

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Apr 18, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Apr 18, 2024

Passing run #8781 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge e5a95a6 into b4af419...
Project: Geotrek-admin Commit: 550834fc0e ℹ️
Status: Passed Duration: 02:15 💡
Started: Apr 18, 2024 4:16 PM Ended: Apr 18, 2024 4:19 PM

Review all test suite changes for PR #4077 ↗︎

@Chatewgne Chatewgne force-pushed the impr_structures_to_aggreg branch 5 times, most recently from c939532 to 5d4cf9e Compare April 18, 2024 16:03
@Chatewgne Chatewgne marked this pull request as ready for review April 18, 2024 16:08
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (b4af419) to head (e5a95a6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4077   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         284      284           
  Lines       20781    20781           
=======================================
  Hits        20447    20447           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne merged commit e182a76 into master Apr 19, 2024
16 checks passed
@Chatewgne Chatewgne deleted the impr_structures_to_aggreg branch April 19, 2024 14:32
@babastienne babastienne mentioned this pull request Apr 22, 2024
20 tasks
@babastienne babastienne changed the title 💫 [IMPR] Add structures to Aggregator (refs #3569) Add structures to Aggregator (refs #3569) May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants