Expose missing Sources in APIv2 (refs #4079) #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #8785 ↗︎
Details:
Review all test suite changes for PR #4080 ↗︎ |
|||||||||||||||
babastienne
approved these changes
Apr 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4080 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 284 284
Lines 20781 20796 +15
=======================================
+ Hits 20447 20462 +15
Misses 334 334 ☔ View full report in Codecov by Sentry. |
Chatewgne
force-pushed
the
fix_apiv2_sources
branch
from
52d0eab
to
cab67f7
Compare
Chatewgne
force-pushed
the
fix_apiv2_sources
branch
from
cab67f7
to
94017f5
Compare
babastienne
changed the title
submarcos
reviewed
May 15, 2024
| set_5 = qs.none() | ||
| if 'geotrek.outdoor' in settings.INSTALLED_APPS: | ||
| set_5 = self.filter_queryset_related_objects_published_by_portal(qs, request, 'sites') | ||
| return (set_1 | set_2 | set_3 | set_4 | set_5).distinct() |
There was a problem hiding this comment.
I suggest to test if set distinct could be done in python to avoid temporary union memery leak in pgsql
(return set(set_1.values_list() + ....))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#4079
Checklist